You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rohit Yadav <bh...@apache.org> on 2015/03/23 11:55:14 UTC

Re: Review Request 28325: Two "VOLUME.DELETE" Events are being registered instead of one - On Destroying a User VM belonging to a Project

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28325/#review77389
-----------------------------------------------------------

Ship it!


Looks good. Please use Github pull request in future as they are more easier to work with.

- Rohit Yadav


On Nov. 21, 2014, 10:54 a.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28325/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2014, 10:54 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-7948
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7948
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> When we destroy a VM it is publishing two VOLUME DELETE events into usage events for ROOT VOLUME.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/listener/VolumeStateListener.java 9fd1423 
> 
> Diff: https://reviews.apache.org/r/28325/diff/
> 
> 
> Testing
> -------
> 
> Tested as a normal user
> Tested as a admin (With and with out pasing expunge flag)
> Tested by attaching Data disks
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>