You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "wnob (via GitHub)" <gi...@apache.org> on 2023/06/20 18:01:19 UTC
[GitHub] [calcite] wnob opened a new pull request, #3276: [CALCITE-5775] Use NULLS FIRST/LAST syntax for BigQuery
wnob opened a new pull request, #3276:
URL: https://github.com/apache/calcite/pull/3276
This may not be a complete solution to CALCITE-5775 but it fixes the issue for BigQuery by using the `NULLS FIRST` / `NULLS LAST` syntax introduced in 2020.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] asfgit closed pull request #3276: [CALCITE-5793] Use NULLS FIRST/LAST syntax for BigQuery
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #3276: [CALCITE-5793] Use NULLS FIRST/LAST syntax for BigQuery
URL: https://github.com/apache/calcite/pull/3276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3276: [CALCITE-5775] Use NULLS FIRST/LAST syntax for BigQuery
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3276:
URL: https://github.com/apache/calcite/pull/3276#issuecomment-1599288374
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3276)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3276&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3276&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3276&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3276&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3276&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3276: [CALCITE-5793] Use NULLS FIRST/LAST syntax for BigQuery
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3276:
URL: https://github.com/apache/calcite/pull/3276#issuecomment-1601807204
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3276)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3276&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3276&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3276&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3276&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3276&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3276&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] wnob commented on a diff in pull request #3276: [CALCITE-5775] Use NULLS FIRST/LAST syntax for BigQuery
Posted by "wnob (via GitHub)" <gi...@apache.org>.
wnob commented on code in PR #3276:
URL: https://github.com/apache/calcite/pull/3276#discussion_r1237795082
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7058,6 +7058,40 @@ private void checkLiteral2(String expression, String expected) {
.withBigQuery().ok(expected);
}
+ /**
+ * Test case for <a href="https://issues.apache.org/jira/browse/CALCITE-5775">[CALCITE-5775]</a>;
+ * make sure BigQuery uses {@code NULLS LAST} syntax.
+ */
+ @Test void testBigQueryUsesNullsLastInsteadOfEmulation() {
+ final Function<RelBuilder, RelNode> relFn = b ->
Review Comment:
I'm thinking now that the 2 existing tests that were affected by this change are enough. They test a `NULLS LAST` and a `DESC NULLS FIRST`. This new test will be for CALCITE-5775 as opposed to CALCITE-5793.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] julianhyde commented on a diff in pull request #3276: [CALCITE-5775] Use NULLS FIRST/LAST syntax for BigQuery
Posted by "julianhyde (via GitHub)" <gi...@apache.org>.
julianhyde commented on code in PR #3276:
URL: https://github.com/apache/calcite/pull/3276#discussion_r1236016445
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7058,6 +7058,40 @@ private void checkLiteral2(String expression, String expected) {
.withBigQuery().ok(expected);
}
+ /**
+ * Test case for <a href="https://issues.apache.org/jira/browse/CALCITE-5775">[CALCITE-5775]</a>;
+ * make sure BigQuery uses {@code NULLS LAST} syntax.
+ */
+ @Test void testBigQueryUsesNullsLastInsteadOfEmulation() {
+ final Function<RelBuilder, RelNode> relFn = b ->
Review Comment:
Could you extend an existing test case, e.g. `testSelectOrderByAscNullsLast` rather than adding a new one?
Or at least add it next to the existing related test cases. (Adding at the end causes conflicts.)
Could the input be SQL rather than RelNode?
Follow the conventional format for javadoc comments. 80 char lines, no semi after `</a>`, include the bug summary inside the `<a>` element.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org