[GitHub] [iceberg] yyanyy commented on a change in pull request #2333: Core: fix bug that HadoopFileIO cannot be dynamically loaded

[GitBox <gi...@apache.org>]

yyanyy commented on a change in pull request #2333:
URL: https://github.com/apache/iceberg/pull/2333#discussion_r594818223



##########
File path: core/src/main/java/org/apache/iceberg/CatalogUtil.java
##########
@@ -197,10 +197,17 @@ public static Catalog buildIcebergCatalog(String name, Map<String, String> optio
   /**
    * Load a custom {@link FileIO} implementation.
    * <p>
-   * The implementation must have a no-arg constructor.
+   * The implementation should have a no-arg constructor.
    * If the class implements {@link Configurable},
    * a Hadoop config will be passed using {@link Configurable#setConf(Configuration)}.
-   * {@link FileIO#initialize(Map properties)} is called to complete the initialization.
+   *
+   * For compatibility with HadoopFileIO,

Review comment:
       I wonder if we starts to support 1-arg constructor as a valid case in the code and prints error messages about it, should we mention this as a fully supported case instead of a backward compatibility support? Especially that the reason for you to choose this option is performance concern. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org