You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/06/05 22:29:35 UTC
[kudu-CR] block placement: test DataDirGroups on old servers
Andrew Wong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7088
Change subject: block placement: test DataDirGroups on old servers
......................................................................
block placement: test DataDirGroups on old servers
This patch adds a test ensuring that servers that ran before commit
732ee211a31335a1b146428b15887d1f26468a3a (whose tablet metadata
files do not have DataDirGroupPBs) will create DataDirGroupPBs upon
starting up.
The test creates a tablet, removes the DataDirGroupPB on-disk, and
restarts the server, ensuring a new group is created.
Change-Id: Id27d7a248c129299fb451ce90519fc16c0a105e4
---
M src/kudu/tserver/tablet_server-test.cc
1 file changed, 31 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/7088/1
--
To view, visit http://gerrit.cloudera.org:8080/7088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id27d7a248c129299fb451ce90519fc16c0a105e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] block placement: test DataDirGroups on old servers
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: block placement: test DataDirGroups on old servers
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7088/1/src/kudu/tserver/tablet_server-test.cc
File src/kudu/tserver/tablet_server-test.cc:
Line 41: using kudu::consensus::RaftConfigPB;
> warning: using decl 'RaftConfigPB' is unused [misc-unused-using-decls]
not your fault, but would you mind removing these?
Line 42: using kudu::consensus::RaftPeerPB;
> warning: using decl 'RaftPeerPB' is unused [misc-unused-using-decls]
same
--
To view, visit http://gerrit.cloudera.org:8080/7088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id27d7a248c129299fb451ce90519fc16c0a105e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] block placement: test DataDirGroups on old servers
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7088
to look at the new patch set (#2).
Change subject: block placement: test DataDirGroups on old servers
......................................................................
block placement: test DataDirGroups on old servers
This patch adds a test ensuring that servers that ran before commit
732ee211a31335a1b146428b15887d1f26468a3a (whose tablet metadata
files do not have DataDirGroupPBs) will create DataDirGroupPBs upon
starting up.
The test creates a tablet, removes the DataDirGroupPB on-disk, and
restarts the server, ensuring a new group is created.
Change-Id: Id27d7a248c129299fb451ce90519fc16c0a105e4
---
M src/kudu/tserver/tablet_server-test.cc
1 file changed, 31 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/7088/2
--
To view, visit http://gerrit.cloudera.org:8080/7088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id27d7a248c129299fb451ce90519fc16c0a105e4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] block placement: test DataDirGroups on old servers
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: block placement: test DataDirGroups on old servers
......................................................................
block placement: test DataDirGroups on old servers
This patch adds a test ensuring that servers that ran before commit
732ee211a31335a1b146428b15887d1f26468a3a (whose tablet metadata
files do not have DataDirGroupPBs) will create DataDirGroupPBs upon
starting up.
The test creates a tablet, removes the DataDirGroupPB on-disk, and
restarts the server, ensuring a new group is created.
Change-Id: Id27d7a248c129299fb451ce90519fc16c0a105e4
Reviewed-on: http://gerrit.cloudera.org:8080/7088
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
---
M src/kudu/tserver/tablet_server-test.cc
1 file changed, 31 insertions(+), 2 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id27d7a248c129299fb451ce90519fc16c0a105e4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] block placement: test DataDirGroups on old servers
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: block placement: test DataDirGroups on old servers
......................................................................
Patch Set 1:
just a couple of nits that are not your fault. so I'm +2ing, feel free to ignore the nits
--
To view, visit http://gerrit.cloudera.org:8080/7088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id27d7a248c129299fb451ce90519fc16c0a105e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] block placement: test DataDirGroups on old servers
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change.
Change subject: block placement: test DataDirGroups on old servers
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7088/1/src/kudu/tserver/tablet_server-test.cc
File src/kudu/tserver/tablet_server-test.cc:
Line 41: using kudu::rpc::Messenger;
> not your fault, but would you mind removing these?
Done
Line 42: using kudu::rpc::MessengerBuilder;
> same
Done
--
To view, visit http://gerrit.cloudera.org:8080/7088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id27d7a248c129299fb451ce90519fc16c0a105e4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] block placement: test DataDirGroups on old servers
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: block placement: test DataDirGroups on old servers
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7088
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id27d7a248c129299fb451ce90519fc16c0a105e4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No