You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:44:01 UTC

[GitHub] [superset] eschutho commented on a change in pull request #16533: feat: Add Cypress makefile cmds

eschutho commented on a change in pull request #16533:
URL: https://github.com/apache/superset/pull/16533#discussion_r699742270



##########
File path: Makefile
##########
@@ -90,3 +90,11 @@ flask-app:
 
 node-app:
 	cd superset-frontend; npm run dev-server
+
+build-cypress:
+	cd superset-frontend; npm run build-instrumented
+	cd superset-frontend/cypress-base; npm install
+
+open-cypress:
+	if ! [ $(port) ]; then cd superset-frontend/cypress-base; CYPRESS_BASE_URL=http://localhost:9000 npm run cypress open; fi
+	cd superset-frontend/cypress-base; CYPRESS_BASE_URL=http://localhost:$(port) npm run cypress open

Review comment:
       yey, this is great!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org