You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Manuel Teira <mt...@tid.es> on 2008/06/25 10:29:23 UTC
cpp/examples/Makefile
Hello. I've already commented about this in the JIRA issue itself, but
after a new commit (670571), cpp/examples/Makefile is still under
version control. Since that Makefile is now generated by autotools,
shouldn't it be taken out of svn ?
Best regards.
Re: cpp/examples/Makefile
Posted by Gordon Sim <gs...@redhat.com>.
Danushka Menikkumbura wrote:
>
>> I don't have commit rights.
> Neither do I :). Either submit a patch or wait until a commiter notices
> the issue.
>
I've removed it now, thanks for pointing that out Manuel!
Re: cpp/examples/Makefile
Posted by Danushka Menikkumbura <da...@wso2.com>.
> I don't have commit rights.
Neither do I :). Either submit a patch or wait until a commiter notices
the issue.
--
Danushka Menikkumbura
Technical Lead, WSO2 Inc.
blog : http://danushka-menikkumbura.blogspot.com/
http://wso2.com/ - The Open Source SOA Company
Re: cpp/examples/Makefile
Posted by Manuel Teira <mt...@tid.es>.
Danushka Menikkumbura escribió:
>> Hello. I've already commented about this in the JIRA issue itself, but
>> after a new commit (670571), cpp/examples/Makefile is still under
>> version control. Since that Makefile is now generated by autotools,
>> shouldn't it be taken out of svn ?
>>
>>
>
> Neither Makefile nor Makefile.in should be added to the SVN as they are
> generated by autotools. So feel free to delete it from SVN.
>
It is actually added as a vestige of its past non-autotools nature. I
feel free to delete it, but I don't have commit rights. So, if you agree
with the inappropriateness of having it under version control, please,
remove it.
Regards.
--
Manuel Teira.
> --
> Danushka Menikkumbura
> Technical Lead, WSO2 Inc.
>
> blog : http://danushka-menikkumbura.blogspot.com/
>
> http://wso2.com/ - The Open Source SOA Company
>
>
>
>
Re: cpp/examples/Makefile
Posted by Danushka Menikkumbura <da...@wso2.com>.
> Hello. I've already commented about this in the JIRA issue itself, but
> after a new commit (670571), cpp/examples/Makefile is still under
> version control. Since that Makefile is now generated by autotools,
> shouldn't it be taken out of svn ?
>
Neither Makefile nor Makefile.in should be added to the SVN as they are
generated by autotools. So feel free to delete it from SVN.
--
Danushka Menikkumbura
Technical Lead, WSO2 Inc.
blog : http://danushka-menikkumbura.blogspot.com/
http://wso2.com/ - The Open Source SOA Company
Re: cpp/examples/Makefile
Posted by Alan Conway <ac...@redhat.com>.
On Wed, 2008-06-25 at 10:29 +0200, Manuel Teira wrote:
> Hello. I've already commented about this in the JIRA issue itself, but
> after a new commit (670571), cpp/examples/Makefile is still under
> version control. Since that Makefile is now generated by autotools,
> shouldn't it be taken out of svn ?
>
> Best regards.
Most definitely, my goof - apologies. Fixed now.