You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/10/19 10:12:04 UTC
[GitHub] vvysotskyi commented on a change in pull request #1507: DRILL-6715:
Update descriptions for System Options table
vvysotskyi commented on a change in pull request #1507: DRILL-6715: Update descriptions for System Options table
URL: https://github.com/apache/drill/pull/1507#discussion_r226591189
##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassTransformer.java
##########
@@ -61,7 +62,10 @@
public final static String SCALAR_REPLACEMENT_OPTION =
"org.apache.drill.exec.compile.ClassTransformer.scalar_replacement";
public final static EnumeratedStringValidator SCALAR_REPLACEMENT_VALIDATOR = new EnumeratedStringValidator(
- SCALAR_REPLACEMENT_OPTION, null, "try", "off", "try", "on");
+ SCALAR_REPLACEMENT_OPTION,
+ new OptionDescription("Enables Drill to attempt scalar replacement. If an error occurs during the attempt, Drill falls back to the previous behavior. Default is 'try'. Accepted values are 'try', 'off', and 'on'. (Drill 0.8+)"),
+ "try", "off", "try", "on");
Review comment:
Please remove duplicated `"try"`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services