You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/28 10:06:55 UTC
[GitHub] [incubator-superset] smacker commented on issue #7611: [sqllab]
Cancel database query on stop
smacker commented on issue #7611: [sqllab] Cancel database query on stop
URL: https://github.com/apache/incubator-superset/pull/7611#issuecomment-525676234
@mistercrunch no. #8097 stops executing list of queries if one of them was stopped.
This PR stops (kills) underlying connection to DB (no matter 1 or more queries are there).
In async mode in SQLLab queries are executed in celery and stop button doesn't really stop them, the task is running until it gets some results from DB. (which may take days)
If you are interested in the fix, I can re-work it using `extra_json` instead of a new field in DB. It will make easier to add support for other backends. (for example for Spark just id isn't enough but special object should be serialized: https://github.com/src-d/sourced-ui/pull/267)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org