You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/06/25 18:00:37 UTC

[GitHub] [trafficserver] bneradt commented on a change in pull request #6945: Build AuTest C/C++ test plugins and utilities with Automake.

bneradt commented on a change in pull request #6945:
URL: https://github.com/apache/trafficserver/pull/6945#discussion_r445739738



##########
File path: tests/tools/plugins/test_cppapi.cc
##########
@@ -115,9 +115,20 @@ f()
   ALWAYS_ASSERT(c2.asTSCont() != nullptr)
   ALWAYS_ASSERT(c2.mutex() == m)
 
-  ALWAYS_ASSERT(!c)
-  ALWAYS_ASSERT(c.asTSCont() == nullptr)
-  ALWAYS_ASSERT(c.mutex() == nullptr)
+  // NOLINTNEXTLINE

Review comment:
       Thank you Randal! Yes, I was trying to treat this as a clang-tidy issue via NOLINT comments but it was instead a clang-format one. The test passes now that I've implemented your feedback.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org