[GitHub] [iceberg] kbendick commented on a diff in pull request #4866: Core / OpenAPI: Add RemoveSnapshotRef to MetadataUpdateParser and OpenAPI spec

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #4866:
URL: https://github.com/apache/iceberg/pull/4866#discussion_r882883906


##########
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##########
@@ -52,6 +52,7 @@ private MetadataUpdateParser() {
   static final String ADD_SNAPSHOT = "add-snapshot";
   static final String REMOVE_SNAPSHOTS = "remove-snapshots";
   static final String SET_SNAPSHOT_REF = "set-snapshot-ref";
+  static final String REMOVE_SNAPSHOT_REF = "remove-snapshot-ref";

Review Comment:
   Nit: Can you move this up to be above `set-snapshot-ref`? This follows the order that the classes are declared in. So move this to line 54 (and let `set-snapshot-ref` go down one line).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org