[jira] [Assigned] (STORM-1078) RateTracker.java is not thread safe

["Robert Joseph Evans (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/STORM-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans reassigned STORM-1078:
------------------------------------------

    Assignee: Robert Joseph Evans

> RateTracker.java is not thread safe
> -----------------------------------
>
>                 Key: STORM-1078
>                 URL: https://issues.apache.org/jira/browse/STORM-1078
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 0.11.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>
> The RateTracker class is not thread safe at all.  It may not be that big of a deal, but the rates will be off if we notify from multiple threads, like we do with disruptor.  It also has the potential to be way off if notify is being called at the same time as updateSlides.  This would result in the new bucket not being set to 0, but getting the old value that was there previously.
> We want to be very careful that what we do does not impact the performance too much.  So ideally no big locks but use AtomicLongs instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)