You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/10/05 22:58:10 UTC
Review Request 39013: RegistryClient refactor: Fixed comments style.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
RegistryClient refactor: Fixed comments style.
Diffs
-----
src/slave/containerizer/provisioner/docker/registry_client.hpp 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185
src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd
Diff: https://reviews.apache.org/r/39013/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 39013: RegistryClient refactor: Fixed comments
style.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 5, 2015, 9:07 p.m., Ben Mahler wrote:
> > I'd like to ship these smaller fixes, but they depend on the large refactor patch and the patch for new functionality, so I can't apply the change :(
> >
> > Please put the small cleanup patches at the front of your change so that they aren't blocked on your other patches, that way we can incrementally commit these :)
s/change/chain/
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/#review101530
-----------------------------------------------------------
On Oct. 5, 2015, 8:58 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39013/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 8:58 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> RegistryClient refactor: Fixed comments style.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/docker/registry_client.hpp 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185
> src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd
>
> Diff: https://reviews.apache.org/r/39013/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39013: RegistryClient refactor: Fixed comments
style.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/#review101530
-----------------------------------------------------------
I'd like to ship these smaller fixes, but they depend on the large refactor patch and the patch for new functionality, so I can't apply the change :(
Please put the small cleanup patches at the front of your change so that they aren't blocked on your other patches, that way we can incrementally commit these :)
- Ben Mahler
On Oct. 5, 2015, 8:58 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39013/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 8:58 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> RegistryClient refactor: Fixed comments style.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/docker/registry_client.hpp 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185
> src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd
>
> Diff: https://reviews.apache.org/r/39013/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39013: RegistryClient refactor: Fixed comments
style.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/#review101554
-----------------------------------------------------------
Hm.. this still depends on https://reviews.apache.org/r/38443/ which introduces new functionality, can you remove that dependency as well please?
- Ben Mahler
On Oct. 5, 2015, 9:21 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39013/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 9:21 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> RegistryClient refactor: Fixed comments style.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/docker/registry_client.hpp 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185
> src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd
>
> Diff: https://reviews.apache.org/r/39013/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39013: RegistryClient refactor: Fixed comments
style.
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/#review101585
-----------------------------------------------------------
BTW, can you update https://issues.apache.org/jira/browse/MESOS-3523 to catch this coding style issue in future?
- Cong Wang
On Oct. 6, 2015, 2:30 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39013/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 2:30 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> RegistryClient refactor: Fixed comments style.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/docker/registry_client.hpp 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185
> src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd
>
> Diff: https://reviews.apache.org/r/39013/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39013: RegistryClient refactor: Fixed comments
style.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/#review101680
-----------------------------------------------------------
Ship it!
Thanks for pulling away the dependencies, I'll commit this shortly without the const change.
src/slave/containerizer/provisioner/docker/registry_client.hpp (line 53)
<https://reviews.apache.org/r/39013/#comment159136>
Ah, please avoid slipping in other changes like this, looks like this belongs in your layer id patch.
- Ben Mahler
On Oct. 6, 2015, 2:30 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39013/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 2:30 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> RegistryClient refactor: Fixed comments style.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/docker/registry_client.hpp 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185
> src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd
>
> Diff: https://reviews.apache.org/r/39013/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 39013: RegistryClient refactor: Fixed comments
style.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 2:30 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Removed dependency on 38443.
Repository: mesos
Description
-------
RegistryClient refactor: Fixed comments style.
Diffs (updated)
-----
src/slave/containerizer/provisioner/docker/registry_client.hpp 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185
src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd
Diff: https://reviews.apache.org/r/39013/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 39013: RegistryClient refactor: Fixed comments
style.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/
-----------------------------------------------------------
(Updated Oct. 5, 2015, 9:21 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
reordered patches.
Repository: mesos
Description
-------
RegistryClient refactor: Fixed comments style.
Diffs (updated)
-----
src/slave/containerizer/provisioner/docker/registry_client.hpp 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185
src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd
Diff: https://reviews.apache.org/r/39013/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese