[jira] [Commented] (AMQCPP-664) Replace std::auto_ptr with std::unique_ptr

["Arjun Ray (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQCPP-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321815#comment-17321815 ] 

Arjun Ray commented on AMQCPP-664:
----------------------------------

Version 3.9.5 is not recognized by the Jira system: 3.9.4 is the latest version recognized.  The patches posted were with respect to v.3.9.5, obtained from

[https://activemq.apache.org/components/cms/download/395-release]

 

 

> Replace std::auto_ptr with std::unique_ptr
> ------------------------------------------
>
>                 Key: AMQCPP-664
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-664
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: CMS Impl
>    Affects Versions: 3.9.4
>            Reporter: Arjun Ray
>            Assignee: Timothy A. Bish
>            Priority: Major
>         Attachments: checkfix.diff, combo.diff, libfix.diff
>
>
> The C\+\+17 standard has eliminated std::auto_ptr, which was deprecated as of C\+\+11 a decade ago.  The code-base will therefore not even compile with modern compilers.
> Replacing std::auto_ptr with std::unique_ptr requires only 6 fix-ups, 5 of which are trivial and actually advisable for the existing code-base anyway, and 1 (in the tests) which exposes a flaw in the existing interfaces yet can be worked around relatively simply.
> [https://mail-archives.apache.org/mod_mbox/activemq-dev/202010.mbox/%3Ctblsoft4dbhg61h2c4cgsian0mevub7567%404ax.com%3E]
>  
> The three patches attached are
>     1. libfix.diff - 3 edits for the library build, while retaining std:;auto_ptr
>     2. checkfix.diff - 3 edits for the tests build, while retaining std::auto_ptr
>     3. combo.diff - everything, including the global search and replace.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)