[GitHub] [dubbo-go] wenxuwan commented on a change in pull request #926: fix client block until timeout when provider return with PackageResponse_Exception

[GitBox <gi...@apache.org>]

wenxuwan commented on a change in pull request #926:
URL: https://github.com/apache/dubbo-go/pull/926#discussion_r541826529



##########
File path: protocol/dubbo/impl/codec.go
##########
@@ -163,15 +163,12 @@ func (c *ProtocolCodec) Decode(p *DubboPackage) error {
 	if p.IsResponseWithException() {
 		logger.Infof("response with exception: %+v", p.Header)
 		decoder := hessian.NewDecoder(body)
+		p.Body = &ResponsePayload{}

Review comment:
       here, p.Body also be nil, so will return perrors.Errorf("java exception:%s", exception.(string)), this will cause the client timeout always.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org