You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/04 01:27:57 UTC
[GitHub] [iceberg] rdblue opened a new pull request #1166: Apply table import test suites to Spark 3
rdblue opened a new pull request #1166:
URL: https://github.com/apache/iceberg/pull/1166
When refactoring Spark support into modules for 2.4 and 3.0, any tests that used `SparkTableUtil` were moved to iceberg-spark2 to avoid needing Scala in the iceberg-spark3 module. Now that #1126 is finished, the tests need to be moved back to the common module and applied in both version-specific modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue closed pull request #1166: Apply table import test suites to Spark 3
Posted by GitBox <gi...@apache.org>.
rdblue closed pull request #1166:
URL: https://github.com/apache/iceberg/pull/1166
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue closed pull request #1166: Apply table import test suites to Spark 3
Posted by GitBox <gi...@apache.org>.
rdblue closed pull request #1166:
URL: https://github.com/apache/iceberg/pull/1166
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1166: Apply table import test suites to Spark 3
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1166:
URL: https://github.com/apache/iceberg/pull/1166#issuecomment-655807759
I tested this locally since CI doesn't seem to be picking it up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1166: Apply table import test suites to Spark 3
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1166:
URL: https://github.com/apache/iceberg/pull/1166
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks commented on pull request #1166: Apply table import test suites to Spark 3
Posted by GitBox <gi...@apache.org>.
danielcweeks commented on pull request #1166:
URL: https://github.com/apache/iceberg/pull/1166#issuecomment-655642873
This look fine to me, but I'm not clear on why we couldn't just create test suite that references the original tests in the spark module as opposed to subclassing new tests in the 2/3 specific modules.
I'm fine with this though. +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1166: Apply table import test suites to Spark 3
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1166:
URL: https://github.com/apache/iceberg/pull/1166#issuecomment-655651717
Just to clarify, the reason why the tests are abstract in the iceberg-spark module is that they cannot run in that module. IcebergSource is only defined in the iceberg-spark2 and iceberg-spark3 modules. We want to use the same tests in those modules, but not run them where there is no defined source that can load tables.
I'll rebase this to fix the conflict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org