You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2010/03/05 10:38:52 UTC
svn commit: r919349 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt
Date: Fri Mar 5 09:38:52 2010
New Revision: 919349
URL: http://svn.apache.org/viewvc?rev=919349&view=rev
Log:
Vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=919349&r1=919348&r2=919349&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Mar 5 09:38:52 2010
@@ -96,7 +96,7 @@
Additional patch:
http://svn.apache.org/viewvc?rev=918803&view=rev
- +1: kkolinko
+ +1: kkolinko, markt
-1:
* Improve logging behaviour when shutdown occurs via a shutdownhook. If present,
@@ -118,6 +118,7 @@
(revisions 910974,918594,918792,918799,918787,918885):
http://people.apache.org/~kkolinko/patches/2010-03-04_tc6_bug48831.patch
+1: kkolinko
+ +1: markt with http://svn.apache.org/viewvc?rev=919347&view=rev
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48827 a regression in
@@ -132,5 +133,5 @@
* Move source/target JDK versions to the main section of the manifest,
because these values belong to the JAR file as the whole, not to some subset of it.
http://svn.apache.org/viewvc?rev=918923&view=rev
- +1: kkolinko, rjung
+ +1: kkolinko, rjung, markt
-1:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r919349 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
On 05/03/2010 13:50, Konstantin Kolinko wrote:
> 2010/3/5 <ma...@apache.org>:
>> Author: markt
>> Date: Fri Mar 5 09:38:52 2010
>> New Revision: 919349
>>
>> URL: http://svn.apache.org/viewvc?rev=919349&view=rev
>> Log:
>> Vote
>>
>
>> * Improve logging behaviour when shutdown occurs via a shutdownhook. If present,
>> @@ -118,6 +118,7 @@
>> (revisions 910974,918594,918792,918799,918787,918885):
>> http://people.apache.org/~kkolinko/patches/2010-03-04_tc6_bug48831.patch
>> +1: kkolinko
>> + +1: markt with http://svn.apache.org/viewvc?rev=919347&view=rev
>
> Re: 919347 ("Ensure read lock is obtained before write lock is
> released on an error condition")
> Mark,
> on error condition we should release all locks and quit the method
> (there is only one lock there: write lock).
> We should not obtain the read lock after an error in that try{} block.
Yep - not enough caffine for me this morning. I'll revert.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r919349 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/3/5 <ma...@apache.org>:
> Author: markt
> Date: Fri Mar 5 09:38:52 2010
> New Revision: 919349
>
> URL: http://svn.apache.org/viewvc?rev=919349&view=rev
> Log:
> Vote
>
> * Improve logging behaviour when shutdown occurs via a shutdownhook. If present,
> @@ -118,6 +118,7 @@
> (revisions 910974,918594,918792,918799,918787,918885):
> http://people.apache.org/~kkolinko/patches/2010-03-04_tc6_bug48831.patch
> +1: kkolinko
> + +1: markt with http://svn.apache.org/viewvc?rev=919347&view=rev
Re: 919347 ("Ensure read lock is obtained before write lock is
released on an error condition")
Mark,
on error condition we should release all locks and quit the method
(there is only one lock there: write lock).
We should not obtain the read lock after an error in that try{} block.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org