You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/09 03:07:49 UTC
[GitHub] [airflow] dstandish opened a new pull request #7110: AIRFLOW-XXXX
improve clarity of confirm message
dstandish opened a new pull request #7110: AIRFLOW-XXXX improve clarity of confirm message
URL: https://github.com/apache/airflow/pull/7110
Clarifies confirm messaging
Before:
```
Forcing response 'no' to rebuild CI.
```
After
```
Forcing response 'no' to 'rebuild CI?'
```
Why?
The sentence `Forcing response 'no' to rebuild CI` can mean "forcing response "no" _in order to_ rebuild CI -- i.e. we must rebuild CI, and to do so, we must force the answer no.
Adding quotes _and_ question mark makes it clear that we are forcing "no" to _the question_ "should we rebuild ci?".
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7110: [AIRFLOW-XXXX] improve
clarity of confirm message
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7110: [AIRFLOW-XXXX] improve clarity of confirm message
URL: https://github.com/apache/airflow/pull/7110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7110: [AIRFLOW-XXXX] improve
clarity of confirm message
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7110: [AIRFLOW-XXXX] improve clarity of confirm message
URL: https://github.com/apache/airflow/pull/7110#issuecomment-572406849
> Adding quotes _and_ question mark makes it clear that we are forcing "no" to _the question_ "should we rebuild ci?".
:D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services