You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/06/04 13:12:28 UTC

[GitHub] [servicecomb-java-chassis] wujimin commented on a change in pull request #1231: [SCB-1304]FallbackPolicy#getFallbackResponse add Throwable

wujimin commented on a change in pull request #1231: [SCB-1304]FallbackPolicy#getFallbackResponse add Throwable
URL: https://github.com/apache/servicecomb-java-chassis/pull/1231#discussion_r290288039
 
 

 ##########
 File path: handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/ThrowExceptionFallbackPolicy.java
 ##########
 @@ -30,7 +30,7 @@ public String name() {
   }
 
   @Override
-  public Response getFallbackResponse(Invocation invocation) {
+  public Response getFallbackResponse(Invocation invocation, Throwable error) {
 
 Review comment:
   need change second parameter from null to error of createBizkeeperException, or not?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services