You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/19 20:05:53 UTC

[GitHub] [beam] chamikaramj commented on a change in pull request #12004: Enabling custom retry strategy for BQ streaming inserts.

chamikaramj commented on a change in pull request #12004:
URL: https://github.com/apache/beam/pull/12004#discussion_r443023182



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/InsertRetryPolicy.java
##########
@@ -33,7 +33,7 @@
    */
   public static class Context {
     // A list of all errors corresponding to an attempted insert of a single record.
-    TableDataInsertAllResponse.InsertErrors errors;

Review comment:
       BTW I think Java standards prefer adding a getter here over making the variable public.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org