You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2017/03/27 08:48:00 UTC

[GitHub] zeppelin pull request #2191: [HOTFIX] Keep interpreter group when save and r...

GitHub user jongyoul opened a pull request:

    https://github.com/apache/zeppelin/pull/2191

    [HOTFIX] Keep interpreter group when save and restart

    ### What is this PR for?
    Not removing interpreter group reference while editing and saving interpreter setting.
    
    ### What type of PR is it?
    [Hot Fix]
    
    ### Todos
    * [x] - Move `loadFromFile` into proper location
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2037
    * #1976 
    
    ### How should this be tested?
    1. Enable shiro for login
    1. Execute sample code by %python and %pyspark
    1. Switch spark interpreter from global mode to Per user mode and save it.
    1. Switch python interpreter from Per user mode to global mode save it.
    1. Shutdown zeppelin
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin hotfix/keep-interpreter-group-when-save-and-restart

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2191
    
----
commit a11ff40d58f9f0d93035d94e09c53dcb606519d9
Author: Jongyoul Lee <jo...@gmail.com>
Date:   2017-03-27T08:35:07Z

    Moved the location of loadFromFile during restarting process

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2191: [HOTFIX] Keep interpreter group when save and r...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul closed the pull request at:

    https://github.com/apache/zeppelin/pull/2191


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2191: [HOTFIX] Keep interpreter group when save and restart

Posted by del680202 <gi...@git.apache.org>.
Github user del680202 commented on the issue:

    https://github.com/apache/zeppelin/pull/2191
  
    I check this PR, it works well, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2191: [HOTFIX] Keep interpreter group when save and restart

Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2191
  
    Tested and It works as your described, LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---