You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2021/09/12 12:07:17 UTC

[dubbo] branch master updated: fix issue-8726 on master: improve code readability (#8749)

This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/master by this push:
     new b7fa549  fix issue-8726 on master: improve code readability (#8749)
b7fa549 is described below

commit b7fa549cfa816bee280b1a2a2e17d91d59118599
Author: changfu <ch...@gmail.com>
AuthorDate: Sun Sep 12 20:07:07 2021 +0800

    fix issue-8726 on master: improve code readability (#8749)
---
 .../src/main/java/org/apache/dubbo/config/ServiceConfig.java      | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
index c133114..e48be1f 100644
--- a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
+++ b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
@@ -658,14 +658,14 @@ public class ServiceConfig<T> extends ServiceConfigBase<T> {
         }
         String portToRegistryStr = getValueFromConfig(protocolConfig, key);
         Integer portToRegistry = parsePort(portToRegistryStr);
-        if (portToRegistry == null) {
-            portToRegistry = portToBind;
+        if (portToRegistry != null) {
+            portToBind = portToRegistry;
         }
 
         // save bind port, used as url's key later
-        map.put(BIND_PORT_KEY, String.valueOf(portToRegistry));
+        map.put(BIND_PORT_KEY, String.valueOf(portToBind));
 
-        return portToRegistry;
+        return portToBind;
     }