You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2016/02/10 00:14:41 UTC
Review Request 43382: Updated Doxyfile to use relative path.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43382/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
Without relative path, Doxygen generated links don't work since they refer to the absolute path.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 96ffc427007b3b1447d291bba0d029646118d4b3
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 6b66bce76838046d7c955188ab9ac05e12756a83
3rdparty/libprocess/include/process/event.hpp c44dc259f240b040aa52234c7d50b1b8cc2566d9
3rdparty/libprocess/include/process/filter.hpp cafa7be065244fe428dee78c5e02e4513f8c1c35
3rdparty/libprocess/include/process/process.hpp c9ef4e86a4735c1c0342793b6d5144d80fc853a9
3rdparty/libprocess/src/process.cpp 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0
Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15
docs/scheduler-http-api.md 42e2c514ad027b9007aadda46eabd5c530f89eaa
include/mesos/scheduler/scheduler.hpp 5d10930e26f1049eeaf16a343bf6efcf95734906
site/source/blog/2016-02-02-mesos-0-27-0-released.md 3be096bf277dc2ebaa0e0c2ed1463b28a58304b3
site/source/index.html.md 727c216a5902cd2bf845c557b3ef0f76a087e971
src/Makefile.am c7507cdb0e029713da0c3218d268f5faf5269b93
src/common/command_utils.cpp 68b7facf62b867ac831ae616dad6623ac271110e
src/master/master.cpp 08d0a86906574ee8381ac2e8809d6b867cc94aa1
src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171
src/tests/common/command_utils_tests.cpp 9207a1bd6e53a8094db47ddecdcb9d39089c4c51
src/tests/reservation_tests.cpp f50ac67c9aadbf229ed8e28031539892eefa9972
src/webui/master/static/browse.html 04a4600f0c762a2412ddee078ba2c173d595aa8d
src/webui/master/static/css/bootstrap-3.0.3.min.css PRE-CREATION
src/webui/master/static/css/bootstrap-3.3.6.min.css 4cf729e4342a51d8b300e8d43f2f78b0a6faf403
src/webui/master/static/framework.html ee42d1ab841a4c42d95512ee60d577b1bbb66bc8
src/webui/master/static/home.html ad3f092a8c7ae2965f2718078c8407e19ae70f10
src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc
src/webui/master/static/slave.html 4735d66c03418ed964a4b720632614e9f9668df7
src/webui/master/static/slave_executor.html 5acb676390fe4ed17369143c5aaaaa13202c0981
src/webui/master/static/slave_framework.html 8d88466c02becd00d7c7bbfc0a4d935aaf299cef
support/apply-reviews.py 8dc1817943d7681b90d64c10bcd82acd7b7cef9d
Diff: https://reviews.apache.org/r/43382/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 43382: Updated Doxyfile to use relative path.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43382/#review120049
-----------------------------------------------------------
Ship it!
Thanks for clarifying! I see what this is doing now.
- Ben Mahler
On Feb. 20, 2016, 4:04 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43382/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2016, 4:04 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> By default, doxygen generated html pages use absolute path for links
> (due to FULL_PATH_NAMES flag set to 'yes'). Thus the links break when
> these pages are moved to a different directory. The fix is to ask
> doxygen to strip out '/path/to/mesos/' from the generated links.
>
>
> Diffs
> -----
>
> Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15
>
> Diff: https://reviews.apache.org/r/43382/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 43382: Updated Doxyfile to use relative path.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43382/
-----------------------------------------------------------
(Updated Feb. 20, 2016, 11:04 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
added a comment.
Repository: mesos
Description (updated)
-------
By default, doxygen generated html pages use absolute path for links
(due to FULL_PATH_NAMES flag set to 'yes'). Thus the links break when
these pages are moved to a different directory. The fix is to ask
doxygen to strip out '/path/to/mesos/' from the generated links.
Diffs (updated)
-----
Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15
Diff: https://reviews.apache.org/r/43382/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 43382: Updated Doxyfile to use relative path.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43382/#review120035
-----------------------------------------------------------
Hm.. I still don't follow from the description what this change is doing.
The testing done section is empty, I assume you've tested this somehow?
Doxyfile (lines 110 - 117)
<https://reviews.apache.org/r/43382/#comment181410>
Can you document for posterity why we set this? I'm having trouble following why this change is being done.
- Ben Mahler
On Feb. 10, 2016, 12:16 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43382/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 12:16 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> By default, doxygen generated html pages use absolute path for links. Thus te links break when these pages are moved to a different directory.
>
>
> Diffs
> -----
>
> Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15
>
> Diff: https://reviews.apache.org/r/43382/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 43382: Updated Doxyfile to use relative path.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43382/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 7:16 p.m.)
Review request for mesos and Ben Mahler.
Repository: mesos
Description (updated)
-------
By default, doxygen generated html pages use absolute path for links. Thus te links break when these pages are moved to a different directory.
Diffs
-----
Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15
Diff: https://reviews.apache.org/r/43382/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 43382: Updated Doxyfile to use relative path.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43382/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 6:22 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased
Repository: mesos
Description (updated)
-------
Updated Doxyfile to use relative path.
Diffs (updated)
-----
Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15
Diff: https://reviews.apache.org/r/43382/diff/
Testing
-------
Thanks,
Kapil Arya