You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by ka...@apache.org on 2016/08/12 02:19:49 UTC
[1/2] storm git commit: STORM-841 Thread-safeness of OutputCollector
has documented contrary to two official doc.
Repository: storm
Updated Branches:
refs/heads/0.10.x-branch a51a28968 -> a29898843
STORM-841 Thread-safeness of OutputCollector has documented contrary to two official doc.
* Fix for 0.10.x
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/baacc0c0
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/baacc0c0
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/baacc0c0
Branch: refs/heads/0.10.x-branch
Commit: baacc0c032f4086c902005c5684bb9093b11d1ff
Parents: a51a289
Author: Jungtaek Lim <ka...@gmail.com>
Authored: Fri Aug 12 08:41:22 2016 +0900
Committer: Jungtaek Lim <ka...@gmail.com>
Committed: Fri Aug 12 08:41:22 2016 +0900
----------------------------------------------------------------------
docs/Concepts.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/baacc0c0/docs/Concepts.md
----------------------------------------------------------------------
diff --git a/docs/Concepts.md b/docs/Concepts.md
index 01dbd11..f920652 100644
--- a/docs/Concepts.md
+++ b/docs/Concepts.md
@@ -65,7 +65,8 @@ When you declare a bolt's input streams, you always subscribe to specific stream
The main method in bolts is the `execute` method which takes in as input a new tuple. Bolts emit new tuples using the [OutputCollector](javadocs/backtype/storm/task/OutputCollector.html) object. Bolts must call the `ack` method on the `OutputCollector` for every tuple they process so that Storm knows when tuples are completed (and can eventually determine that its safe to ack the original spout tuples). For the common case of processing an input tuple, emitting 0 or more tuples based on that tuple, and then acking the input tuple, Storm provides an [IBasicBolt](javadocs/backtype/storm/topology/IBasicBolt.html) interface which does the acking automatically.
-Its perfectly fine to launch new threads in bolts that do processing asynchronously. [OutputCollector](javadocs/backtype/storm/task/OutputCollector.html) is thread-safe and can be called at any time.
+Please note that [OutputCollector](javadocs/backtype/storm/task/OutputCollector.html) is not thread-safe, and all emits, acks, and fails must happen on the same thread. Please refer [Troubleshooting](troubleshooting.html) for more details.
+
**Resources:**
[2/2] storm git commit: Merge branch 'STORM-841-0.10.x' into
0.10.x-branch
Posted by ka...@apache.org.
Merge branch 'STORM-841-0.10.x' into 0.10.x-branch
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/a2989884
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/a2989884
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/a2989884
Branch: refs/heads/0.10.x-branch
Commit: a29898843f5b2abe51d90c30e98b31e530a802e0
Parents: a51a289 baacc0c
Author: Jungtaek Lim <ka...@gmail.com>
Authored: Fri Aug 12 11:18:55 2016 +0900
Committer: Jungtaek Lim <ka...@gmail.com>
Committed: Fri Aug 12 11:18:55 2016 +0900
----------------------------------------------------------------------
docs/Concepts.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------