You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Jorg Heymans <jh...@domek.be> on 2004/09/14 13:47:37 UTC
[PATCH] wd references
The defaultselectionlistbuilder was still expecting wd: (woody?) elements.
Doing a grep in src/blocks/forms/java/org/apache/cocoon/forms reveals a
few more of these, summarized below. I can provide a patch for these as
well if wanted :=)
./datatype/DefaultSelectionListBuilder.java
./datatype/DynamicSelectionList.java
./datatype/EnumSelectionList.java
./datatype/EnumSelectionList.java
./datatype/FlowJXPathSelectionListBuilder.java
./formmodel/Field.java
./formmodel/Field.java
./formmodel/Field.java
./formmodel/MultiValueField.java
./formmodel/MultiValueField.java
./formmodel/MultiValueField.java
./formmodel/RepeaterActionDefinitionBuilder.java
./formmodel/RepeaterActionDefinitionBuilder.java
./formmodel/RepeaterActionDefinitionBuilder.java
./formmodel/SubmitDefinitionBuilder.java
./formmodel/SubmitDefinitionBuilder.java
Index:
src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java
===================================================================
---
src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java
(revision 46019)
+++
src/blocks/forms/java/org/apache/cocoon/forms/datatype/DefaultSelectionListBuilder.java
(working copy)
@@ -41,7 +41,7 @@
* <p>Note: the class {@link DynamicSelectionList} also interprets the
same wd:selection-list XML, so if
* anything changes here to how that XML is interpreted, it also needs
to change over there and vice versa.
*
- * @version CVS $Id: DefaultSelectionListBuilder.java,v 1.4 2004/05/06
14:59:44 bruno Exp $
+ * @version CVS $Id$
*/
public class DefaultSelectionListBuilder implements
SelectionListBuilder, Serviceable {
@@ -128,7 +128,7 @@
Document document = DomHelper.parse(inputSource);
Element selectionListElement = document.getDocumentElement();
if
(!Constants.DEFINITION_NS.equals(selectionListElement.getNamespaceURI())
|| !"selection-list".equals(selectionListElement.getLocalName()))
- throw new Exception("Excepted a wd:selection-list
element at " + DomHelper.getLocation(selectionListElement));
+ throw new Exception("Expected a fd:selection-list
element at " + DomHelper.getLocation(selectionListElement));
return selectionListElement;
} finally {
if (source != null) {
Re: [PATCH] wd references
Posted by Vadim Gritsenko <va...@reverycodes.com>.
Jorg Heymans wrote:
> minor: you might also want to change "Excepted" to "Expected" in
> DefaultSelectionListBuilder.java.
Thanks
Vadim
Re: [PATCH] wd references
Posted by Jorg Heymans <jh...@domek.be>.
minor: you might also want to change "Excepted" to "Expected" in
DefaultSelectionListBuilder.java.
Vadim Gritsenko wrote:
> Jorg Heymans wrote:
>
>> The defaultselectionlistbuilder was still expecting wd: (woody?)
>> elements.
>>
>> Doing a grep in src/blocks/forms/java/org/apache/cocoon/forms reveals
>> a few more of these, summarized below. I can provide a patch for these
>> as well if wanted :=)
>>
>>
>> ./datatype/DefaultSelectionListBuilder.java
>> ./datatype/DynamicSelectionList.java
>> ./datatype/EnumSelectionList.java
>> ./datatype/FlowJXPathSelectionListBuilder.java
>> ./formmodel/Field.java
>> ./formmodel/MultiValueField.java
>> ./formmodel/RepeaterActionDefinitionBuilder.java
>> ./formmodel/SubmitDefinitionBuilder.java
>
>
> Fixed wd, wi references which I found in the files.
>
> Vadim
>
Re: [PATCH] wd references
Posted by Vadim Gritsenko <va...@reverycodes.com>.
Jorg Heymans wrote:
> The defaultselectionlistbuilder was still expecting wd: (woody?) elements.
>
> Doing a grep in src/blocks/forms/java/org/apache/cocoon/forms reveals a
> few more of these, summarized below. I can provide a patch for these as
> well if wanted :=)
>
>
> ./datatype/DefaultSelectionListBuilder.java
> ./datatype/DynamicSelectionList.java
> ./datatype/EnumSelectionList.java
> ./datatype/FlowJXPathSelectionListBuilder.java
> ./formmodel/Field.java
> ./formmodel/MultiValueField.java
> ./formmodel/RepeaterActionDefinitionBuilder.java
> ./formmodel/SubmitDefinitionBuilder.java
Fixed wd, wi references which I found in the files.
Vadim