You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/02/21 11:57:52 UTC
[GitHub] [maven] cstamas opened a new pull request #450: [MNG-7097] Plugin Dependency Resolution Improvement
cstamas opened a new pull request #450:
URL: https://github.com/apache/maven/pull/450
Implements a helper component for plugin dependency resolution that provider
filter and selector that leaves out core artifacts from collection
and resolution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #450: [MNG-7097] Plugin Dependency Resolution Improvement
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #450:
URL: https://github.com/apache/maven/pull/450#issuecomment-782915543
Something is strange: for example this one fails (on GH but also locally as well):
```
mng7045 DropUselessAndOutdatedCdiApi.it().................... FAILURE (0.3 s)
```
**but**, when I run the POM in IT from CLI (is simple, uses GMavenPlus plugin and a script), it passes ok...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas edited a comment on pull request #450: [MNG-7097] Plugin Dependency Resolution Improvement
Posted by GitBox <gi...@apache.org>.
cstamas edited a comment on pull request #450:
URL: https://github.com/apache/maven/pull/450#issuecomment-782915543
Something is strange: for example this one fails (on GH but also locally as well):
```
mng7045 DropUselessAndOutdatedCdiApi.it().................... FAILURE (0.3 s)
```
**but**, when I run the POM in IT from CLI with this PR built mvn it is OK (is simple, uses GMavenPlus plugin and a script)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] pzygielo commented on a change in pull request #450: [MNG-7097] Plugin Dependency Resolution Improvement
Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #450:
URL: https://github.com/apache/maven/pull/450#discussion_r579799094
##########
File path: maven-core/src/main/java/org/apache/maven/extension/internal/CoreExportsProvider.java
##########
@@ -27,7 +27,8 @@
import org.eclipse.sisu.Nullable;
/**
- * CoreExportsProvider
+ * CoreExportsProvider, that CANNOT be <tty>javax.inject.Provider</tty> as ctor would have circular dep.
Review comment:
`javadoc: error: unknown tag: tty`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on a change in pull request #450: [MNG-7097] Plugin Dependency Resolution Improvement
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #450:
URL: https://github.com/apache/maven/pull/450#discussion_r579799693
##########
File path: maven-core/src/main/java/org/apache/maven/extension/internal/CoreExportsProvider.java
##########
@@ -27,7 +27,8 @@
import org.eclipse.sisu.Nullable;
/**
- * CoreExportsProvider
+ * CoreExportsProvider, that CANNOT be <tty>javax.inject.Provider</tty> as ctor would have circular dep.
Review comment:
Fixed, tx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org