[GitHub] [incubator-inlong] dockerzhang commented on a diff in pull request #4062: [INLONG-3636][TubeMQ] Fix the warning logs during the build

[GitBox <gi...@apache.org>]

dockerzhang commented on code in PR #4062:
URL: https://github.com/apache/incubator-inlong/pull/4062#discussion_r864918750


##########
inlong-tubemq/tubemq-manager/src/main/assembly/assembly.xml:
##########
@@ -21,7 +21,6 @@
           xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.1.0 http://maven.apache.org/xsd/assembly-2.1.0.xsd">
     <id>bin</id>
     <formats>
-        <format>dir</format>

Review Comment:
   ditto



##########
inlong-tubemq/tubemq-example/src/main/assembly/assembly.xml:
##########
@@ -18,7 +18,6 @@
 <assembly>
     <id>demo</id>
     <formats>
-        <format>dir</format>

Review Comment:
   ditto



##########
inlong-tubemq/tubemq-client/src/main/assembly/assembly.xml:
##########
@@ -18,7 +18,6 @@
 <assembly>
     <id>bin</id>
     <formats>
-        <format>dir</format>

Review Comment:
   here we should keep the dir format, because it may be used in https://github.com/apache/incubator-inlong/blob/master/inlong-distribution/distribution.xm to package the whole binary package.



##########
inlong-tubemq/tubemq-server/src/main/assembly/assembly.xml:
##########
@@ -18,7 +18,6 @@
 <assembly>
     <id>bin</id>
     <formats>
-        <format>dir</format>

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org