You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/05/08 00:20:33 UTC

Review Request 21179: Added test for killing an unknown task.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21179/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Bugs: MESOS-1321
    https://issues.apache.org/jira/browse/MESOS-1321


Repository: mesos-git


Description
-------

see summary


Diffs
-----

  src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42 

Diff: https://reviews.apache.org/r/21179/diff/


Testing
-------

make check


Thanks,

Dominic Hamon

Re: Review Request 21179: Added test for killing an unknown task.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21179/#review42585
-----------------------------------------------------------

Ship it!


Thanks, I'll get this committed, with a comment describing what this test is doing.


src/tests/master_tests.cpp
<https://reviews.apache.org/r/21179/#comment76399>

    How about:
    
    // This test ensures that a killTask for an unknown task results in a
    // TASK_LOST when there are no slaves in transitionary states.


- Ben Mahler


On May 7, 2014, 10:20 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21179/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 10:20 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1321
>     https://issues.apache.org/jira/browse/MESOS-1321
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42 
> 
> Diff: https://reviews.apache.org/r/21179/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>