You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2018/07/18 16:20:51 UTC

qpid-jms git commit: QPIDJMS-403: adjust test to account for changes, avoid spurious failure in CI

Repository: qpid-jms
Updated Branches:
  refs/heads/master 3244adc3a -> 8b200671e


QPIDJMS-403: adjust test to account for changes, avoid spurious failure in CI


Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/8b200671
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/8b200671
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/8b200671

Branch: refs/heads/master
Commit: 8b200671ed7a449b5b565b5926b7b8850f010007
Parents: 3244adc
Author: Robbie Gemmell <ro...@apache.org>
Authored: Wed Jul 18 17:16:48 2018 +0100
Committer: Robbie Gemmell <ro...@apache.org>
Committed: Wed Jul 18 17:16:48 2018 +0100

----------------------------------------------------------------------
 .../qpid/jms/provider/failover/FailoverIntegrationTest.java    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/8b200671/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/failover/FailoverIntegrationTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/failover/FailoverIntegrationTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/failover/FailoverIntegrationTest.java
index 4e3128e..7297e81 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/failover/FailoverIntegrationTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/failover/FailoverIntegrationTest.java
@@ -1962,7 +1962,7 @@ public class FailoverIntegrationTest extends QpidJmsTestCase {
     }
 
     @Test(timeout=20000)
-    public void testTxCommitThrowsAfterMaxReconnectsWhenNoDischargeResponseSent() throws Exception {
+    public void testTxCommitThrowsWhenNoDischargeResponseSentAndConnectionDrops() throws Exception {
         try (TestAmqpPeer testPeer = new TestAmqpPeer()) {
 
             final CountDownLatch testConnected = new CountDownLatch(1);
@@ -1978,7 +1978,7 @@ public class FailoverIntegrationTest extends QpidJmsTestCase {
             testPeer.expectBegin();
 
             final JmsConnection connection = establishAnonymousConnecton(
-                "failover.maxReconnectAttempts=10&failover.useReconnectBackOff=false", testPeer);
+                "failover.maxReconnectAttempts=3&failover.useReconnectBackOff=false", testPeer);
             connection.addConnectionListener(new JmsDefaultConnectionListener() {
                 @Override
                 public void onConnectionEstablished(URI remoteURI) {
@@ -1996,7 +1996,7 @@ public class FailoverIntegrationTest extends QpidJmsTestCase {
             });
             connection.start();
 
-            assertTrue("Should connect to test peer", testConnected.await(5, TimeUnit.SECONDS));
+            assertTrue("Should connect to test peer", testConnected.await(6, TimeUnit.SECONDS));
 
             testPeer.expectBegin();
             testPeer.expectCoordinatorAttach();


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org