You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2008/05/02 02:37:55 UTC

[jira] Created: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Name-node fails to start because DatanodeInfo format changed.
-------------------------------------------------------------

                 Key: HADOOP-3337
                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
             Project: Hadoop Core
          Issue Type: Bug
    Affects Versions: 0.18.0
            Reporter: Konstantin Shvachko
            Assignee: Tsz Wo (Nicholas), SZE
            Priority: Blocker
             Fix For: 0.18.0


HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
Particularly, reading edits generated by the previous version of hadoop throws the following exception:
{code}
08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
/56.313
	at java.lang.Enum.valueOf(Enum.java:192)
	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
{code}
and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593784#action_12593784 ] 

Raghu Angadi commented on HADOOP-3337:
--------------------------------------

> Example use: [...]
Actually this is not a potential problem, rather real one. Most unit tests fail with this patch.

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-3337:
---------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thanks Nicholas!

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch, 3337_20080502.patch, 3337_20080502b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593703#action_12593703 ] 

Raghu Angadi commented on HADOOP-3337:
--------------------------------------

Does it mean the current patch is ok?

But we should not have wrong implementations of Writable interface for DatanodeDescriptor, right? 

Could you describe the fix (and may be problem)?

> We will remove storing DatanodeDescriptor to FSEditLog In HADOOP-3329 soon.

What this stored before HADOOP-3283? 

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593703#action_12593703 ] 

rangadi edited comment on HADOOP-3337 at 5/1/08 8:15 PM:
--------------------------------------------------------------

Does it mean the current patch is ok?

But we should not have wrong implementations of Writable interface for DatanodeDescriptor, right? 

Could you describe the fix (and may be problem)?

> We will remove storing DatanodeDescriptor to FSEditLog In HADOOP-3329 soon.

Was this stored before HADOOP-3283? 

      was (Author: rangadi):
    Does it mean the current patch is ok?

But we should not have wrong implementations of Writable interface for DatanodeDescriptor, right? 

Could you describe the fix (and may be problem)?

> We will remove storing DatanodeDescriptor to FSEditLog In HADOOP-3329 soon.

What this stored before HADOOP-3283? 
  
> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594877#action_12594877 ] 

Hudson commented on HADOOP-3337:
--------------------------------

Integrated in Hadoop-trunk #483 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/483/])

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch, 3337_20080502.patch, 3337_20080502b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3337:
-------------------------------------------

    Attachment: 3337_20080502.patch

Raghu, thank you for pointing out that DatanodeDescriptor is sent in RPC in some hidden way.

3337_20080502.patch: created a subclass to fix this bug.

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch, 3337_20080502.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593897#action_12593897 ] 

Konstantin Shvachko commented on HADOOP-3337:
---------------------------------------------

DatanodeDescriptor is not sent over RPC and is not supposed to. You can never get DatanodeDescriptor on the other end.
DatanodeDescriptor is sort of a name-node private class.
Although the actual class is DatanodeDescriptor, rpc serializes the base class DatanodeInfo  
using its Writable implementation and sends the latter over the network.
The problem here is that the serialization intended for DatanodeDescriptor (which is only serialized to disk) 
is mixed with the serialization of DatanodeInfo  (which should be used only for rpc).
We have been through this before.
I think we should introduce 2 new static methods in the DatanodeDescriptor that would provide serialization to disk.

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch, 3337_20080502.patch, 3337_20080502b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593701#action_12593701 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-3337:
------------------------------------------------

> I think this needs to be fixed better. 

I agree.  We will remove storing DatanodeDescriptor to FSEditLog In HADOOP-3329 soon.  Therefore, I don't want to introduce layout change or protocol change in this patch.

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593998#action_12593998 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-3337:
------------------------------------------------

Tested manually.

The 4 new javac warnings are due to the use of UTF8 for backward compatibility.

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch, 3337_20080502.patch, 3337_20080502b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593698#action_12593698 ] 

Konstantin Shvachko commented on HADOOP-3337:
---------------------------------------------

DatanodeDescriptor is not used in RPC only DatanodeInfo.

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593706#action_12593706 ] 

Raghu Angadi commented on HADOOP-3337:
--------------------------------------

> DatanodeDescriptor is not used in RPC only DatanodeInfo.

Sure it is. Even if it is not, I don't think its a good practice to silently break the contract because we think the contract is not used (yet), (especially for widely used interfaces like Writables)

Example use: ClientProtocol.getBlockLocations() returns {{LocatedBlocks}}, if you trace its implementation, you will see that LocatedBlock is created using DatanodeDescriptor (around FSNamesystem.java:747) .. so DatanodeDescriptor.read() etc do get called out side of FSEditLog.


> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3337:
-------------------------------------------

    Status: Open  (was: Patch Available)

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch, 3337_20080502.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3337:
-------------------------------------------

    Attachment:     (was: 3334_20080501.patch)

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3337:
-------------------------------------------

    Attachment: 3334_20080501.patch

3334_20080501.patch: revert the accident change of FSEditLog in HADOOP-3283.

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3337:
-------------------------------------------

    Attachment: 3337_20080501.patch

3334_20080501.patch => 3337_20080501.patch

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3337:
-------------------------------------------

    Status: Patch Available  (was: Open)

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593981#action_12593981 ] 

Hadoop QA commented on HADOOP-3337:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12381344/3337_20080502b.patch
against trunk revision 645773.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac -1.  The applied patch generated 462 javac compiler warnings (more than the trunk's current 458 warnings).

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2371/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2371/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2371/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2371/console

This message is automatically generated.

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch, 3337_20080502.patch, 3337_20080502b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593697#action_12593697 ] 

Raghu Angadi commented on HADOOP-3337:
--------------------------------------

Wouldn't this affect readFields() and write() of DatanodeDescriptor (used everywhere : RPCs etc) ? This patch looks like a problematic hack. I think this needs to be fixed better. If EditLog requires to read and write differently these different serialization should used there instead of everywhere.

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3337:
-------------------------------------------

    Status: Patch Available  (was: Open)

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch, 3337_20080502.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3337:
-------------------------------------------

    Attachment: 3337_20080501b.patch

3337_20080501b.patch: incorporated Konstantin's comments.

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3337:
-------------------------------------------

    Attachment: 3337_20080502b.patch

3337_20080502b.patch: use static methods instead of subclass.

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch, 3337_20080502.patch, 3337_20080502b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593687#action_12593687 ] 

Konstantin Shvachko commented on HADOOP-3337:
---------------------------------------------

This patch works on my old file system image. Minor comments, please
- remove import of UTF8
- provide comments on the 2 new methods *FSEditLog() explaining what they are for.

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-3337:
----------------------------------------

    Component/s: dfs

> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (HADOOP-3337) Name-node fails to start because DatanodeInfo format changed.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593681#action_12593681 ] 

szetszwo edited comment on HADOOP-3337 at 5/1/08 6:38 PM:
------------------------------------------------------------------------

3334_20080501.patch: reverted the accidental changes of FSEditLog format in HADOOP-3283.

      was (Author: szetszwo):
    3334_20080501.patch: revert the accident change of FSEditLog in HADOOP-3283.
  
> Name-node fails to start because DatanodeInfo format changed.
> -------------------------------------------------------------
>
>                 Key: HADOOP-3337
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3337
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: 3337_20080501.patch, 3337_20080501b.patch
>
>
> HADOOP-3283 introduced a new field ipcPort in DatanodeInfo, which was not reflected in the reading/writing file system image files.
> Particularly, reading edits generated by the previous version of hadoop throws the following exception:
> {code}
> 08/05/02 00:02:50 ERROR dfs.NameNode: java.lang.IllegalArgumentException: No enum const class org.apache.hadoop.dfs.DatanodeInfo$AdminStates.0?
> /56.313
> 	at java.lang.Enum.valueOf(Enum.java:192)
> 	at org.apache.hadoop.io.WritableUtils.readEnum(WritableUtils.java:399)
> 	at org.apache.hadoop.dfs.DatanodeInfo.readFields(DatanodeInfo.java:318)
> 	at org.apache.hadoop.io.ArrayWritable.readFields(ArrayWritable.java:90)
> 	at org.apache.hadoop.dfs.FSEditLog.loadFSEdits(FSEditLog.java:499)
> 	at org.apache.hadoop.dfs.FSImage.loadFSEdits(FSImage.java:794)
> 	at org.apache.hadoop.dfs.FSImage.loadFSImage(FSImage.java:664)
> 	at org.apache.hadoop.dfs.FSImage.recoverTransitionRead(FSImage.java:280)
> 	at org.apache.hadoop.dfs.FSDirectory.loadFSImage(FSDirectory.java:81)
> 	at org.apache.hadoop.dfs.FSNamesystem.initialize(FSNamesystem.java:276)
> 	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:257)
> 	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:133)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:178)
> 	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:164)
> 	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:777)
> 	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:786)
> {code}
> and startup fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.