[jira] [Commented] (SPARK-8382) Improve Analysis Unit test framework

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661379#comment-14661379 ] 

Apache Spark commented on SPARK-8382:
-------------------------------------

User 'cloud-fan' has created a pull request for this issue:
https://github.com/apache/spark/pull/8025

> Improve Analysis Unit test framework
> ------------------------------------
>
>                 Key: SPARK-8382
>                 URL: https://issues.apache.org/jira/browse/SPARK-8382
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>            Reporter: Michael Armbrust
>
> We have some nice frameworks for doing various unit test {{checkAnswer}}, {{comparePlan}}, {{checkEvaluation}}, etc.  However {{AnalysisSuite}} is kind of sloppy with each test using assertions in different ways.  I'd like a function that looks something like the following:
> {code}
> def checkAnalysis(
>   inputPlan: LogicalPlan,
>   expectedPlan: LogicalPlan = null,
>   caseInsensitiveOnly: Boolean = false,
>   expectedErrors: Seq[String] = Nil)
> {code}
> This function should construct tests that check the Analyzer works as expected and provides useful error messages when any failures are encountered.  We should then rewrite the existing tests and beef up our coverage here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org