Re: [PR] [SPARK-55981][SQL] Allow Geo Types with SRID's from the pre-built registry [spark]

["uros-db (via GitHub)" <gi...@apache.org>]

uros-db commented on code in PR #54780:
URL: https://github.com/apache/spark/pull/54780#discussion_r2997354188


##########
sql/core/src/test/java/org/apache/spark/sql/internal/types/SpatialReferenceSystemMapperSuite.java:
##########
@@ -50,51 +49,137 @@ record TestCase(int srid, String stringId, boolean isGeographic) {}
 
   @Test
   public void getStringIdReturnsCorrectStringIdForValidSrid() {
-    // GEOMETRY.
+    // GEOMETRY: Spark-specific and OGC override entries.
     Assertions.assertEquals("SRID:0", CartesianSpatialReferenceSystemMapper.getStringId(0));
     Assertions.assertEquals("EPSG:3857", CartesianSpatialReferenceSystemMapper.getStringId(3857));
     Assertions.assertEquals("OGC:CRS84", CartesianSpatialReferenceSystemMapper.getStringId(4326));
+    Assertions.assertEquals("OGC:CRS27", CartesianSpatialReferenceSystemMapper.getStringId(4267));
+    Assertions.assertEquals("OGC:CRS83", CartesianSpatialReferenceSystemMapper.getStringId(4269));
+    // GEOMETRY: PROJ-sourced registry entries (no override).
+    Assertions.assertEquals("EPSG:32601", CartesianSpatialReferenceSystemMapper.getStringId(32601));

Review Comment:
   ```suggestion
       // GEOMETRY: PROJ-sourced registry entries (no override).
       Assertions.assertEquals("EPSG:32601", CartesianSpatialReferenceSystemMapper.getStringId(32601));
       Assertions.assertEquals("ESRI:102013", CartesianSpatialReferenceSystemMapper.getStringId(102013));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org