You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/04/25 08:03:35 UTC
svn commit: r1889162 -
/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java
Author: tilman
Date: Sun Apr 25 08:03:34 2021
New Revision: 1889162
URL: http://svn.apache.org/viewvc?rev=1889162&view=rev
Log:
PDFBOX-4892: use try-with-resources
Modified:
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java?rev=1889162&r1=1889161&r2=1889162&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/rendering/TestRendering.java Sun Apr 25 08:03:34 2021
@@ -64,20 +64,21 @@ class TestRendering
}
@ParameterizedTest(name = "{index} render running for {0}")
- @MethodSource("dataSubset")
+ @MethodSource("dataSubset")
void render(String fileName) throws IOException
{
File file = new File(INPUT_DIR, fileName);
- PDDocument document = Loader.loadPDF(file);
- PDFRenderer renderer = new PDFRenderer(document);
-
- // We don't actually do anything with the image for the same reason that
- // TestPDFToImage is disabled - different JVMs produce different results
- // but at least we can make sure that PDFBox did not throw any exceptions
- // during the rendering process.
-
- assertDoesNotThrow(() -> renderer.renderImage(0));
- document.close();
+ try (PDDocument document = Loader.loadPDF(file))
+ {
+ PDFRenderer renderer = new PDFRenderer(document);
+
+ // We don't actually do anything with the image for the same reason that
+ // TestPDFToImage is disabled - different JVMs produce different results
+ // but at least we can make sure that PDFBox did not throw any exceptions
+ // during the rendering process.
+
+ assertDoesNotThrow(() -> renderer.renderImage(0));
+ }
}
/*
@@ -85,7 +86,7 @@ class TestRendering
* Enable and visually inspect failing tests files.
*/
// @ParameterizedTest(name = "{index} render and compare running for {0}")
- @MethodSource("data")
+ @MethodSource("data")
void renderAndCompare(String fileName) throws IOException
{