You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branden Robinson <br...@deadbeast.net> on 2005/01/24 05:26:44 UTC

[ALTERNATE PATCH] Limit size of emails sent using commit-email.pl

On Wed, Jan 12, 2005 at 02:13:01PM -0000, Max Bowsher wrote:
> VK Sameer wrote:
> >Hello,
> >
> >Minor patch to commit-email.pl.in to truncate large commit emails. I've
> >added two variables, one for difflines and one for the email body later,
> >not sure if that's overkill.
> 
> Do we really need two? It seems overly complicated to me.
> I'd be perfectly happy with either one or the other, but I don't like the 
> idea of both.

I'm attaching a patch I've been using for the Subversion repository of
Debian's XFree86 packages for several months.

It attempts only to limit the size of the outbound mail.

You can also review this diff and the patched script at the following
location:
  http://necrotic.deadbeast.net/tmp/commit-email.pl
  http://necrotic.deadbeast.net/tmp/commit-email.pl.diff

I'm also attaching my post-commit hook.

Here's a link to a recent example of the patched script working:
  Message-Id: <20...@necrotic.deadbeast.net>
  http://lists.debian.org/debian-x/2005/01/msg00238.html

-- 
G. Branden Robinson            |       The Rehnquist Court has never
Free Software Developer        |       encountered a criminal statute it
branden@deadbeast.net          |       did not like.
http://deadbeast.net/~branden/ |       -- John Dean

Re: [ALTERNATE PATCH] Limit size of emails sent using commit-email.pl

Posted by Michael W Thelen <mi...@pietdepsi.com>.
Branden Robinson wrote:
> I'm attaching a patch I've been using for the Subversion repository of
> Debian's XFree86 packages for several months.
>
> It attempts only to limit the size of the outbound mail.

Thank you for the patch.  I've filed both your patch and the one from VK
Sameer in issue #2213:
http://subversion.tigris.org/issues/show_bug.cgi?id=2213

--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams