You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2016/10/28 17:59:40 UTC
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Alex Behm has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4879
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Add functional tests for compute stats with mt_dop > 0.
Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
---
A testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test
M tests/query_test/test_mt_dop.py
2 files changed, 20 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/4879/1
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4879/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test
File testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test:
Line 3: compute stats alltypes
> The existing compute stats test does not systematically run on all file for
works for me, i just wanted to make sure we have enough coverage to release it as "mt works for compute stats".
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4879/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test
File testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test:
Line 3: compute stats alltypes
> works for me, i just wanted to make sure we have enough coverage to release
fair point, I don't think it gives us complete confidence, but we do get basic functional coverage and a guard against regressions
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4879/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test
File testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test:
Line 3: compute stats alltypes
why create this test case instead of running the existing 'compute stats' tests?
http://gerrit.cloudera.org:8080/#/c/4879/3/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:
Line 34: # IMPALA-4332: The MT scheduler does not work for Kudu or HBase tables.
just a reminder: this will change with the next set of coordinator changes.
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has uploaded a new patch set (#3).
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Add functional tests for compute stats with mt_dop > 0.
Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
---
A testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test
M tests/query_test/test_mt_dop.py
2 files changed, 21 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/4879/3
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4879/1/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:
PS1, Line 52: location
> Maybe add a comment "Create a second table pointing to the same data files"
Done
http://gerrit.cloudera.org:8080/#/c/4879/2/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:
PS2, Line 50: tion("
> format
Done
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Hello Marcel Kornacker, Lars Volker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4879
to look at the new patch set (#4).
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Add functional tests for compute stats with mt_dop > 0.
Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
---
A testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test
M tests/query_test/test_mt_dop.py
2 files changed, 23 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/4879/4
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 3: Code-Review-2
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4879/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test
File testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test:
Line 3: compute stats alltypes
> why create this test case instead of running the existing 'compute stats' t
The existing compute stats test does not systematically run on all file formats, and several of the .test files have insert/ctas that don't work with mt_dop. Refactoring the existing test_compute_stats.py and .test file seemed much harder. I'm not even sure we want to run all the obscure regression tests with mt_dop as well.
I'm happy to refactor the existing tests if you feel strongly, but that's going to take some time.
http://gerrit.cloudera.org:8080/#/c/4879/3/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:
Line 34: # IMPALA-4332: The MT scheduler does not work for Kudu or HBase tables.
> just a reminder: this will change with the next set of coordinator changes.
Thanks. On my radar.
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 4: Verified-1
Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/397/
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has uploaded a new patch set (#2).
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Add functional tests for compute stats with mt_dop > 0.
Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
---
A testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test
M tests/query_test/test_mt_dop.py
2 files changed, 20 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/4879/2
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 4: Code-Review+2
Got fixed by Henry's scheduler fix.
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4879/1/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:
PS1, Line 51: execute_query_using_client
> That version doesn't switch the DB and extracting the DB manually from the
Cool, learned something.
PS1, Line 52: location
> I want to just create "clone" of an existing table that has the same format
Maybe add a comment "Create a second table pointing to the same data files"?
http://gerrit.cloudera.org:8080/#/c/4879/2/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:
PS2, Line 50: fotmat
format
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Add functional tests for compute stats with mt_dop > 0.
Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Reviewed-on: http://gerrit.cloudera.org:8080/4879
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Internal Jenkins
---
A testdata/workloads/functional-query/queries/QueryTest/mt-dop-compute-stats.test
M tests/query_test/test_mt_dop.py
2 files changed, 23 insertions(+), 3 deletions(-)
Approvals:
Internal Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 4:
Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/398/
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4879/1/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:
PS1, Line 51: execute_query_using_client
I think self.execute_query does the same.
PS1, Line 52: location
Why is it necessary to change the location here? I'm mostly curious because I did something similar in a different change and didn't specify a location, so the data files ended up in the unique_database's directory.
Line 54: new_vector = deepcopy(vector)
can you add a comment why this copy step is needed?
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4879/1/tests/query_test/test_mt_dop.py
File tests/query_test/test_mt_dop.py:
PS1, Line 51: execute_query_using_client
> I think self.execute_query does the same.
That version doesn't switch the DB and extracting the DB manually from the vector is super painful. Added comment.
PS1, Line 52: location
> Why is it necessary to change the location here? I'm mostly curious because
I want to just create "clone" of an existing table that has the same format and points to the same files. Create table like does not copy the location, so I need to specify it. Alternatives like CTAS don't work because it's not easy to specify the format in the CTAS, and we cannot insert into all formats.
Line 54: new_vector = deepcopy(vector)
> can you add a comment why this copy step is needed?
For this test it's actually not needed because in every test we set the mt_dop exec option again. I was worried about modifying the vector in place and polluting the state of subsequent tests, but all tests use and set mt_dop anyway.
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 4:
This ran on a jenkins worker who hit JENKINS-300 several times. I suspect this was the case here, too.
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Add functional tests for compute stats with mt dop > 0.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Add functional tests for compute stats with mt_dop > 0.
......................................................................
Patch Set 3: Code-Review-1
Hits DCHECK now, need to debug.
--
To view, visit http://gerrit.cloudera.org:8080/4879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No