You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/18 11:54:58 UTC
[GitHub] [incubator-doris] liutang123 commented on a diff in pull request #9065: [fix](storage) Disable compaction before schema change is actually executed(#9032)
liutang123 commented on code in PR #9065:
URL: https://github.com/apache/incubator-doris/pull/9065#discussion_r852066025
##########
be/src/olap/tablet.cpp:
##########
@@ -275,6 +277,23 @@ void Tablet::modify_rowsets(std::vector<RowsetSharedPtr>& to_add,
same_version = false;
}
+ if (check_delete) {
+ for (auto& rs : to_delete) {
+ auto find_rs = _rs_version_map.find(rs->version());
Review Comment:
It is necessary to get write lock of `_meta_lock` before exec `Tablet::modify_rowsets`. So, we need not lock `_meta_lock ` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org