You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2015/09/07 14:38:47 UTC
[GitHub] cordova-lib pull request: CB-9407 Fixes incorrect applying of plug...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/296
CB-9407 Fixes incorrect applying of plugin-provided config changes.
See [CB-9407](https://issues.apache.org/jira/browse/CB-9407) for details. This PR is an alternative to #274, reworked according to recent changes (PlatformApi).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9407
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #296
----
commit 1b539e6385b62987c8b6e3b77c582bce944ffa9c
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-09-07T10:01:22Z
CB-9407 Fixes incorrect applying of plugin-provided config changes.
This resolves #274
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9407 Fixes incorrect applying of plug...
Posted by zalun <gi...@git.apache.org>.
Github user zalun commented on the pull request:
https://github.com/apache/cordova-lib/pull/296#issuecomment-138376173
r+
test on file-transform plugin under firefoxos
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9407 Fixes incorrect applying of plug...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/296#issuecomment-148442647
@zalun - this fix will be in the next minor/major release (whichever comes first) - the only change included in 5.3.3 was a patch to support node 4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9407 Fixes incorrect applying of plug...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/296
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9407 Fixes incorrect applying of plug...
Posted by zalun <gi...@git.apache.org>.
Github user zalun commented on the pull request:
https://github.com/apache/cordova-lib/pull/296#issuecomment-147739558
It's still not working in off the shelf cordova...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9407 Fixes incorrect applying of plug...
Posted by zalun <gi...@git.apache.org>.
Github user zalun commented on the pull request:
https://github.com/apache/cordova-lib/pull/296#issuecomment-148409135
master is fine, it's the Cordova 5.3.3 which still doesn't have this fix ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9407 Fixes incorrect applying of plug...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/296#issuecomment-148325630
@zalun, just tried create a new blank app with file-transfer and geolocation plugins, and it seems to fork for me:
_config.xml_:
```xml
<permission name="systemXHR" privileged="true" />
<permission description="Required for accessing user location." name="geolocation" />
```
_manifest.webapp_:
```json
"permissions": {
"systemXHR": {},
"geolocation": {
"description": "Required for accessing user location."
}
}
```
Could you please double check, if the issue still exists using latest `master`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org