[GitHub] [spark] sunchao commented on a diff in pull request #42777: [SPARK-45054][SQL] HiveExternalCatalog.listPartitions should restore partition statistics

["sunchao (via GitHub)" <gi...@apache.org>]

sunchao commented on code in PR #42777:
URL: https://github.com/apache/spark/pull/42777#discussion_r1313521002


##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala:
##########
@@ -1290,6 +1291,7 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf: Configurat
         res.filter(p => isPartialPartitionSpec(spec, toMetaStorePartitionSpec(p.spec)))
       case _ => res
     }
+    parts.map(restorePartitionMetadata(_, catalogTable))

Review Comment:
   Yes looks like not all operations are updated with `restorePartitionMetadata`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org