You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by masaori335 <gi...@git.apache.org> on 2015/11/30 09:46:58 UTC
[GitHub] trafficserver pull request: TS-3986: Cleanup code related to HTTP/...
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/354
TS-3986: Cleanup code related to HTTP/2 frame flags validation
[TS-3986](https://issues.apache.org/jira/browse/TS-3986)
Separate Pull-Request from #353 to easy to review.
1. Rename http2_are_frame_flags_valid to http2_frame_flags_are_valid
2. Move list of masks to HTTP2.h from HTTP2.cc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/masaori335/trafficserver TS-3986_cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/354.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #354
----
commit 734d1becea03a0dbb2eee2a5b259a50a15307024
Author: Masaori Koshiba <mk...@yahoo-corp.jp>
Date: 2015-11-24T07:33:35Z
TS-3986: Cleanup code related to HTTP/2 frame flags validation
1. Rename http2_are_frame_flags_valid to http2_frame_flags_are_valid
2. Move list of masks to HTTP2.h from HTTP2.cc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3986: Cleanup code related to HTTP/...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/354
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3986: Cleanup code related to HTTP/...
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/354#issuecomment-160793948
Rebased with latest master branch. Please take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3986: Cleanup code related to HTTP/...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/354#issuecomment-160761247
There are conflicts with the patch after applying previous pull requests. Please update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---