You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/08/12 06:22:06 UTC
[GitHub] [hive] viirya opened a new pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
viirya opened a new pull request #1395:
URL: https://github.com/apache/hive/pull/1395
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to upgrade Guava to 27 in Hive branch-2. This is basically used to trigger test for #1394.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When trying to upgrade Guava in Spark, found the following error. A Guava method became package-private since Guava version 20. So there is incompatibility with Guava versions > 19.0.
```
sbt.ForkMain$ForkError: sbt.ForkMain$ForkError: java.lang.IllegalAccessError: tried to access method com.google.common.collect.Iterators.emptyIterator()Lcom/google/common/collect/UnmodifiableIterator; from class org.apache.hadoop.hive.ql.exec.FetchOperator
at org.apache.hadoop.hive.ql.exec.FetchOperator.<init>(FetchOperator.java:108)
at org.apache.hadoop.hive.ql.exec.FetchTask.initialize(FetchTask.java:87)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:541)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1317)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1457)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1237)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1227)
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. This upgrades Guava to 27.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Built Hive locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674444649
Hm, I don't see Accumulo test failure there http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-1395/1/tests.
Tried to run `org.apache.hadoop.hive.cli.TestAccumuloCliDriver` locally, but seems it was stuck.
I also ran it in current branch-2, but it's also stuck.
Is this correct way to run this test?
```
mvn clean -Dtest=org.apache.hadoop.hive.cli.TestAccumuloCliDriver -q -Pitests test
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1395:
URL: https://github.com/apache/hive/pull/1395
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674414949
@kgyrtkirk I see there is a timeout of 6 hours in Jenkinsfile, curious how the test can still run for so long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674549118
@sunchao Technically, if we shade Guava in Hive, we should be able to work with Hadoop 2.7.2 without conflict with its older Guava.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674558602
I mean Hive. Not sure if it is correct, but I think if we shade Guava in Hive, is Hadoop 2.7.2 which depends on older Guava still a problem here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-672634649
@sunchao Yeah, seems the tests was triggered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674459062
@viirya Regardless of this, like you mentioned, the biggest blocker for this is Hadoop 2.7.2 which depends on a lower version of Guava, and I don't see a way to solve this other than upgrading the Hadoop version (Hadoop only start shading Guava from 3.0.0 I think).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674396933
TestAccumuloCliDriver was running for 3 days - I stopped it...maybe this change also needs an accululo upgrade?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya edited a comment on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674558602
I mean Hive. Not sure if it is correct, but I think if we shade Guava in Hive, is Hadoop 2.7.2 which depends on older Guava still a problem here? By shading Guava in Hive, I think Hive can use newer Guava, and let Hadoop uses older Guava?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674424834
Ah I see. @viirya do you see the Accumulo test failures related?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674560110
You can try. I think the hive-exec JAR produced will have no issue working with older version of Hadoop/Guava, but I don't know others like unit tests work in this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya edited a comment on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674558602
I mean Hive. Not sure if it is totally correct or I may miss anything, but I think if we shade Guava in Hive, is Hadoop 2.7.2 which depends on older Guava still a problem here? By shading Guava in Hive, I think Hive can use newer Guava, and let Hadoop uses older Guava?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674592619
Hm, ok, let me try to shade Guava too in this PR, and see how it goes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674417843
on branch-2 I don't see any timeout set...that's why it could run indefinetly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674458822
@viirya I think just
```
cd itests
mvn clean test -Dtest=org.apache.hadoop.hive.cli.TestAccumuloCliDriver
```
is suffice. You also need to build the itests module first.
For me, the test on branch-2 didn't stuck but failed with the following error:
```
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256M; support was removed in 8.0
Running org.apache.hadoop.hive.cli.TestAccumuloCliDriver
Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 163.852 sec <<< FAILURE! - in org.apache.hadoop.hive.cli.TestAccumuloCliDriver
testCliDriver[accumulo_queries](org.apache.hadoop.hive.cli.TestAccumuloCliDriver) Time elapsed: 62.901 sec <<< FAILURE!
java.lang.AssertionError:
Unexpected exception java.lang.AssertionError: Client Execution results failed with error code = 1 while executing fname=accumulo_queries.q
at org.junit.Assert.fail(Assert.java:88)
at org.apache.hadoop.hive.ql.QTestUtil.failedDiff(QTestUtil.java:2201)
at org.apache.hadoop.hive.cli.control.CoreAccumuloCliDriver.runTest(CoreAccumuloCliDriver.java:97)
at org.apache.hadoop.hive.cli.control.CliAdapter.runTest(CliAdapter.java:104)
at org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver(TestAccumuloCliDriver.java:59)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.apache.hadoop.hive.cli.control.CliAdapter$2$1.evaluate(CliAdapter.java:92)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.junit.runners.Suite.runChild(Suite.java:127)
at org.junit.runners.Suite.runChild(Suite.java:26)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.apache.hadoop.hive.cli.control.CliAdapter$1$1.evaluate(CliAdapter.java:73)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
```
So don't understand why it stuck for so long in the CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-672634424
cc @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674557187
> we should be able to work with Hadoop 2.7.2 ...
@viirya You mean Spark, right? I think #1356 is promising but upgrading Guava to 27 is much harder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1395: HIVE-23998: Upgrade guava to 27 for Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1395:
URL: https://github.com/apache/hive/pull/1395#issuecomment-674425402
Not check it yet, I will look at it later today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org