You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Trygve Laugstol (JIRA)" <ji...@codehaus.org> on 2006/04/07 09:54:48 UTC
[jira] Commented: (CONTINUUM-651)
DefaultContinuumScm.getScmRepository should not set project scm
username/password if they are the empty string
[ http://jira.codehaus.org/browse/CONTINUUM-651?page=comments#action_63048 ]
Trygve Laugstol commented on CONTINUUM-651:
-------------------------------------------
Why?
> DefaultContinuumScm.getScmRepository should not set project scm username/password if they are the empty string
> --------------------------------------------------------------------------------------------------------------
>
> Key: CONTINUUM-651
> URL: http://jira.codehaus.org/browse/CONTINUUM-651
> Project: Continuum
> Type: Bug
> Components: Core system
> Reporter: John Didion
>
>
> Should be using StringUtils.isEmpty instead of doing a null check.
> {noformat}
> if ( !StringUtils.isEmpty(project.getScmUsername()) )
> {
> providerRepository.setUser( project.getScmUsername() );
> if ( project.getScmPassword() != null )
> {
> providerRepository.setPassword( project.getScmPassword() );
> }
> else
> {
> providerRepository.setPassword( "" );
> }
> }
> {noformat}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira