[GitHub] [geode] jinmeiliao commented on a change in pull request #6225: GEODE-9101: fix VisibleNode attribute in MemberMXBean

[GitBox <gi...@apache.org>]

jinmeiliao commented on a change in pull request #6225:
URL: https://github.com/apache/geode/pull/6225#discussion_r608917610



##########
File path: geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
##########
@@ -1881,9 +1881,8 @@ public void handleManagerDeparture(InternalDistributedMember theId, boolean memb
     removeHostedLocators(theId);
     redundancyZones.remove(theId);
 
-    if (theId.getVmKind() != ClusterDistributionManager.LOCATOR_DM_TYPE) {
-      stats.incNodes(-1);
-    }
+    stats.incNodes(-1);
+

Review comment:
       From the original code, it looks like it doesn't think a locator should be included in the count, so, shouldn't the correct count should be:
   
   ```
   Locator 1: 2 (count Server 1 and Server 2) 
   Locator 2: 2 (count Server 1 and Server 2)
   Server 1: 2 (count Server 1 and Server 2) 
   Server 2: 2 (count Server 1 and Server 2)
   ```
   instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org