You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Berenguer Blasi (Jira)" <ji...@apache.org> on 2020/11/04 09:01:00 UTC
[jira] [Comment Edited] (CASSANDRA-15583) 4.0 quality testing:
Tooling, Bundled and First Party
[ https://issues.apache.org/jira/browse/CASSANDRA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210016#comment-17210016 ]
Berenguer Blasi edited comment on CASSANDRA-15583 at 11/4/20, 9:00 AM:
-----------------------------------------------------------------------
So this is trickier than expected as some commands need a node to run properly. So I managed to make {{ToolRunner}} work against jvm-dtests nodetool commands. I also looked at the sstable utils you mentioned and it's going to need some hacking as well. You'll need sstables to upgrade from that the CQLTester instance is aware of etc..
For starters I got nodetool ring test up so far. I will update here as I make progress:
* nodetool
** ring CASSANDRA-16200 (up for review)
** tablestats CASSANDRA-16227
** tpstats CASSANDRA-16230
** netstats CASSANDRA-16227
** disablebinary CASSANDRA-16230
** enablebinary CASSANDRA-16230
** gossipinfo CASSANDRA-16230
* sstableupgrade CASSANDRA-16011
* sstablescrub
was (Author: bereng):
So this is trickier than expected as some commands need a node to run properly. So I managed to make {{ToolRunner}} work against jvm-dtests nodetool commands. I also looked at the sstable utils you mentioned and it's going to need some hacking as well. You'll need sstables to upgrade from that the CQLTester instance is aware of etc..
For starters I got nodetool ring test up so far. I will update here as I make progress:
* nodetool
** ring CASSANDRA-16200 (up for review)
** tablestats CASSANDRA-16227
** tpstats CASSANDRA-16230
** netstats CASSANDRA-16227
** disablebinary CASSANDRA-16230
** enablebinary CASSANDRA-16230
** gossipinfo CASSANDRA-16230
* sstableupgrade
* sstablescrub
> 4.0 quality testing: Tooling, Bundled and First Party
> -----------------------------------------------------
>
> Key: CASSANDRA-15583
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15583
> Project: Cassandra
> Issue Type: Task
> Components: Test/dtest/python, Test/unit
> Reporter: Josh McKenzie
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0-beta
>
>
> Reference [doc from NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] for context.
> *Shepherd: Sam Tunnicliffe*
> Test plans should cover bundled first-party tooling and CLIs such as nodetool, cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983, CASSANDRA-12151).
> *Progress as of Aug 2020*
> {{ToolRunner}} has been added enabling us to test tools in java unit tests. This includes capturing their stdout/err and stdin i.e. Most tools have a starting unit test testing their cmd line args happy path. Tickets have been created to improve coverage of those and flagged LHF. Also for those tools big enough they can't be addressed in a simple ticket such as nodetool, a placeholder ticket for future improvements has been created as well. Tickets and status are:
> ||Tool||UX test||UT coverage||dtest coverage||Comments||
> |Nodetool|(x)|(x) CASSANDRA-16026|(!)|Not all the sub commands are tested. Dtest also test nodetool as a side effect|
> |Cqlsh|(x)|(x) CASSANDRA-16025|(!)| |
> |Cassandra-stress|(x)|(x) CASSANDRA-16024|(x)| |
> |debug-cql|(x)|(x) CASSANDRA-16023|(x)| |
> |fqltool|(x)|(/) CASSANDRA-16022|(!)| |
> |auditlogviewer|(/) CASSANDRA-15991|(!) CASSANDRA-16021|(!)| |
> |*Sstable utilities*| | | | |
> |sstabledump|(/) CASSANDRA-15991|(/) CASSANDRA-16020|(!)| |
> |sstableexpiredblockers|(/) CASSANDRA-15991|(x) CASSANDRA-16019|(!)| |
> |sstablelevelreset|(/) CASSANDRA-15991|(x) CASSANDRA-16018|(!)| |
> |sstableloader|(x)|(x) CASSANDRA-16017|(!)| |
> |sstablemetadata|(/) CASSANDRA-15991|(x) CASSANDRA-16016|(x)|Ran in dtests, no dedicated test|
> |sstableofflinerelevel|(/) CASSANDRA-15991|(x) CASSANDRA-16015|(!)| |
> |sstablerepairedset|(/) CASSANDRA-15991|(x) CASSANDRA-16014|(x)|Ran in dtests, no dedicated test|
> |sstablescrub|(/) CASSANDRA-15991|(x) CASSANDRA-16013|(!)| |
> |sstablesplit|(/) CASSANDRA-15991|(x) CASSANDRA-16012|(!)| |
> |sstableupgrade|(/) CASSANDRA-15991|(x) CASSANDRA-16011|(!)| |
> |sstableutil|(/) CASSANDRA-15991|(x) CASSANDRA-16010|(!)| |
> |sstableverify|(/) CASSANDRA-15991|(x) CASSANDRA-16009|(!)| |
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org