You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/26 15:05:44 UTC
[GitHub] [incubator-apisix] membphis opened a new pull request #1910: bugfix: should not save the runtime data of plugin into `etcd`.
membphis opened a new pull request #1910:
URL: https://github.com/apache/incubator-apisix/pull/1910
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
as title.
fixed #1836 .
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] spacewander commented on a change in pull request #1910: bugfix: should not save the runtime data of plugin into `etcd`.
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #1910:
URL: https://github.com/apache/incubator-apisix/pull/1910#discussion_r460601114
##########
File path: apisix/core/json.lua
##########
@@ -26,6 +27,7 @@ local cached_tab = {}
local _M = {
version = 0.1,
decode = require("cjson.safe").decode,
+ sort_encode = require("apisix.core.json_sort").encode,
Review comment:
Better to use name `encode_with_keys_sorted`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming commented on a change in pull request #1910: bugfix: should not save the runtime data of plugin into `etcd`.
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1910:
URL: https://github.com/apache/incubator-apisix/pull/1910#discussion_r460609651
##########
File path: apisix/core/json.lua
##########
@@ -26,6 +27,7 @@ local cached_tab = {}
local _M = {
version = 0.1,
decode = require("cjson.safe").decode,
+ sort_encode = require("apisix.core.json_sort").encode,
Review comment:
Is this function only for test cases?
##########
File path: apisix/core/json_sort.lua
##########
@@ -0,0 +1,104 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
Review comment:
we should not put this file to `core` if it only for test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis merged pull request #1910: bugfix: should not save the runtime data of plugin into `etcd`.
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1910:
URL: https://github.com/apache/incubator-apisix/pull/1910
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org