You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/31 05:03:46 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request, #23214: Adjust DatabaseDiscoveryDataSourceRule getDataSourceMapper for primary datasource first
strongduanmu opened a new pull request, #23214:
URL: https://github.com/apache/shardingsphere/pull/23214
Ref #23133.
Changes proposed in this pull request:
- adjust DatabaseDiscoveryDataSourceRule getDataSourceMapper for primary datasource first
- add unit test
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23214: Adjust DatabaseDiscoveryDataSourceRule getDataSourceMapper for primary datasource first
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23214:
URL: https://github.com/apache/shardingsphere/pull/23214#issuecomment-1368168280
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23214?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23214](https://codecov.io/gh/apache/shardingsphere/pull/23214?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (913c7ba) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6b9f510befc1a41e7597ef50edfe382117f6c26f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b9f510) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #23214 +/- ##
=========================================
Coverage 49.70% 49.71%
Complexity 2441 2441
=========================================
Files 4018 4018
Lines 57484 57487 +3
Branches 9119 9119
=========================================
+ Hits 28574 28579 +5
+ Misses 26375 26374 -1
+ Partials 2535 2534 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...stsql/parser/core/MaskDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/23214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvbWFzay9kaXN0c3FsL3BhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWFzay9kaXN0c3FsL3BhcnNlci9jb3JlL01hc2tEaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <ø> (ø)` | |
| [...iscovery/rule/DatabaseDiscoveryDataSourceRule.java](https://codecov.io/gh/apache/shardingsphere/pull/23214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L3J1bGUvRGF0YWJhc2VEaXNjb3ZlcnlEYXRhU291cmNlUnVsZS5qYXZh) | `80.64% <100.00%> (+2.07%)` | :arrow_up: |
| [...ontend/executor/ConnectionThreadExecutorGroup.java](https://codecov.io/gh/apache/shardingsphere/pull/23214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvZXhlY3V0b3IvQ29ubmVjdGlvblRocmVhZEV4ZWN1dG9yR3JvdXAuamF2YQ==) | `86.66% <0.00%> (+13.33%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #23214: Adjust DatabaseDiscoveryDataSourceRule getDataSourceMapper for primary datasource first
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #23214:
URL: https://github.com/apache/shardingsphere/pull/23214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org