You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltacloud.apache.org by "Dies Koper (JIRA)" <ji...@apache.org> on 2012/05/04 08:14:51 UTC
[jira] [Created] (DTACLOUD-210) various small GUI improvements: use
hyperlinks for FWs and volumes in instances, allow name to be specified for
new volumes, display name when available, don't use hyperlink for 'unknown'
instances, don't use <--> if no device specified
Dies Koper created DTACLOUD-210:
-----------------------------------
Summary: various small GUI improvements: use hyperlinks for FWs and volumes in instances, allow name to be specified for new volumes, display name when available, don't use hyperlink for 'unknown' instances, don't use <--> if no device specified
Key: DTACLOUD-210
URL: https://issues.apache.org/jira/browse/DTACLOUD-210
Project: DeltaCloud
Issue Type: Improvement
Components: Server
Reporter: Dies Koper
Assignee: David Lutterkort
Priority: Minor
Various small GUI improvements:
- use hyperlinks for FWs and volumes in instances to those resources
- allow optional name to be specified for new volumes
- use volume name instead of id for volume name when available
- rename create button to 'attach' to attach a volume to an instance
- don't use hyperlinks for 'unknown', for detached volumes
- don't use <--> separator in instances' volume list if no device specified (such as for FGCP)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DTACLOUD-210) various small GUI improvements: use
hyperlinks for FWs and volumes in instances, allow name to be specified for
new volumes, display name when available, don't use hyperlink for 'unknown'
instances, don't use <--> if no device specified
Posted by "Marios Andreou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marios Andreou closed DTACLOUD-210.
-----------------------------------
pushed to master - commit hash 862c7cbe31159449ae1411902966620323b7f279
(I included the minor edit to display 'none (detached)' rather than 'unknown' for the HTML UI when a storage volume is detached - as discussed with the patch author in the ticket comments.)
> various small GUI improvements: use hyperlinks for FWs and volumes in instances, allow name to be specified for new volumes, display name when available, don't use hyperlink for 'unknown' instances, don't use <--> if no device specified
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DTACLOUD-210
> URL: https://issues.apache.org/jira/browse/DTACLOUD-210
> Project: DeltaCloud
> Issue Type: Improvement
> Components: Server
> Reporter: Dies Koper
> Assignee: Marios Andreou
> Priority: Minor
> Attachments: 0001-use-hyperlinks-for-firewall-entries-in-instance-show.patch, 0002-use-volume-name-instead-of-id-for-volume-name-if-ava.patch, 0003-change-button-name-for-volume-attaching-from-create-.patch, 0004-don-t-use-hyperlink-for-unknown-for-detached-volume.patch, 0005-don-t-show-separator-if-no-device-name-available.patch, 0006-use-hyperlinks-for-attached-volumes-in-instance-show.patch, 0007-allow-volume-name-to-be-specified-in-GUI.patch
>
>
> Various small GUI improvements:
> - use hyperlinks for FWs and volumes in instances to those resources
> - allow optional name to be specified for new volumes
> - use volume name instead of id for volume name when available
> - rename create button to 'attach' to attach a volume to an instance
> - don't use hyperlinks for 'unknown', for detached volumes
> - don't use <--> separator in instances' volume list if no device specified (such as for FGCP)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DTACLOUD-210) various small GUI improvements:
use hyperlinks for FWs and volumes in instances, allow name to be specified
for new volumes, display name when available, don't use hyperlink for
'unknown' instances, don't use <--> if no device specified
Posted by "Marios Andreou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278866#comment-13278866 ]
Marios Andreou commented on DTACLOUD-210:
-----------------------------------------
ACK - all patches apply cleanly and improvements all seem sane. 1 minor comment (just so you know i've actually looked ;) ):
Patch 4/7: when a volume is not attached I think it would be even better to just show 'none' rather than unknown for the "Attached To"...
diff --git a/server/views/storage_volumes/show.html.haml b/server/views/storage_volumes/show.html.haml
index 6575175..62e7f8d 100644
--- a/server/views/storage_volumes/show.html.haml
+++ b/server/views/storage_volumes/show.html.haml
<<SNIP>>...
@@ -20,8 +20,11 @@
%p{ :'data-role' => 'fieldcontain'}=@storage_volume.state
%li{ :'data-role' => 'list-divider'} Attached to
%li
- %a{ :href => instance_url( @storage_volume.instance_id)}
- = @storage_volume.instance_id || 'unknown'
+ - if @storage_volume.instance_id
+ %a{ :href => instance_url( @storage_volume.instance_id)}
+ = @storage_volume.instance_id
+ - else
+ %p{ :'data-role' => 'fieldcontain'}= 'unknown'
-elsif @storage_volume.state == "AVAILABLE"
%p{ :'data-role' => 'fieldcontain'}= 'none'
-else
%p{ :'data-role' => 'fieldcontain'}= 'unknown'
This can be addressed in a future patch though - would probably be a pita to have to go back and change this minor thing. The only thing stopping me from pushing these now is that you forgot to tick the 'for inclusion in ASF works' box in the uploads. Do you already have a signed Apache CLA? Otherwise can you give some other indication that you grant license for these files to be included? A note here should suffice imho...
> various small GUI improvements: use hyperlinks for FWs and volumes in instances, allow name to be specified for new volumes, display name when available, don't use hyperlink for 'unknown' instances, don't use <--> if no device specified
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DTACLOUD-210
> URL: https://issues.apache.org/jira/browse/DTACLOUD-210
> Project: DeltaCloud
> Issue Type: Improvement
> Components: Server
> Reporter: Dies Koper
> Assignee: David Lutterkort
> Priority: Minor
> Attachments: 0001-use-hyperlinks-for-firewall-entries-in-instance-show.patch, 0002-use-volume-name-instead-of-id-for-volume-name-if-ava.patch, 0003-change-button-name-for-volume-attaching-from-create-.patch, 0004-don-t-use-hyperlink-for-unknown-for-detached-volume.patch, 0005-don-t-show-separator-if-no-device-name-available.patch, 0006-use-hyperlinks-for-attached-volumes-in-instance-show.patch, 0007-allow-volume-name-to-be-specified-in-GUI.patch
>
>
> Various small GUI improvements:
> - use hyperlinks for FWs and volumes in instances to those resources
> - allow optional name to be specified for new volumes
> - use volume name instead of id for volume name when available
> - rename create button to 'attach' to attach a volume to an instance
> - don't use hyperlinks for 'unknown', for detached volumes
> - don't use <--> separator in instances' volume list if no device specified (such as for FGCP)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DTACLOUD-210) various small GUI improvements:
use hyperlinks for FWs and volumes in instances, allow name to be specified
for new volumes, display name when available, don't use hyperlink for
'unknown' instances, don't use <--> if no device specified
Posted by "Dies Koper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279466#comment-13279466 ]
Dies Koper commented on DTACLOUD-210:
-------------------------------------
I agree on the 'none' instead of 'unknown'. Feel free to amend my patch accordingly.
Apologies about forgetting to tick the box: I grant license to ASF for inclusion in ASF works and have sent the signed CLA in February to the appropriate Apache contact address (and received confirmation of reception).
> various small GUI improvements: use hyperlinks for FWs and volumes in instances, allow name to be specified for new volumes, display name when available, don't use hyperlink for 'unknown' instances, don't use <--> if no device specified
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DTACLOUD-210
> URL: https://issues.apache.org/jira/browse/DTACLOUD-210
> Project: DeltaCloud
> Issue Type: Improvement
> Components: Server
> Reporter: Dies Koper
> Assignee: Marios Andreou
> Priority: Minor
> Attachments: 0001-use-hyperlinks-for-firewall-entries-in-instance-show.patch, 0002-use-volume-name-instead-of-id-for-volume-name-if-ava.patch, 0003-change-button-name-for-volume-attaching-from-create-.patch, 0004-don-t-use-hyperlink-for-unknown-for-detached-volume.patch, 0005-don-t-show-separator-if-no-device-name-available.patch, 0006-use-hyperlinks-for-attached-volumes-in-instance-show.patch, 0007-allow-volume-name-to-be-specified-in-GUI.patch
>
>
> Various small GUI improvements:
> - use hyperlinks for FWs and volumes in instances to those resources
> - allow optional name to be specified for new volumes
> - use volume name instead of id for volume name when available
> - rename create button to 'attach' to attach a volume to an instance
> - don't use hyperlinks for 'unknown', for detached volumes
> - don't use <--> separator in instances' volume list if no device specified (such as for FGCP)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DTACLOUD-210) various small GUI improvements:
use hyperlinks for FWs and volumes in instances, allow name to be specified
for new volumes, display name when available, don't use hyperlink for
'unknown' instances, don't use <--> if no device specified
Posted by "Marios Andreou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marios Andreou resolved DTACLOUD-210.
-------------------------------------
Resolution: Fixed
Assignee: Marios Andreou (was: David Lutterkort)
waiting for comment from author and will push these patches
> various small GUI improvements: use hyperlinks for FWs and volumes in instances, allow name to be specified for new volumes, display name when available, don't use hyperlink for 'unknown' instances, don't use <--> if no device specified
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DTACLOUD-210
> URL: https://issues.apache.org/jira/browse/DTACLOUD-210
> Project: DeltaCloud
> Issue Type: Improvement
> Components: Server
> Reporter: Dies Koper
> Assignee: Marios Andreou
> Priority: Minor
> Attachments: 0001-use-hyperlinks-for-firewall-entries-in-instance-show.patch, 0002-use-volume-name-instead-of-id-for-volume-name-if-ava.patch, 0003-change-button-name-for-volume-attaching-from-create-.patch, 0004-don-t-use-hyperlink-for-unknown-for-detached-volume.patch, 0005-don-t-show-separator-if-no-device-name-available.patch, 0006-use-hyperlinks-for-attached-volumes-in-instance-show.patch, 0007-allow-volume-name-to-be-specified-in-GUI.patch
>
>
> Various small GUI improvements:
> - use hyperlinks for FWs and volumes in instances to those resources
> - allow optional name to be specified for new volumes
> - use volume name instead of id for volume name when available
> - rename create button to 'attach' to attach a volume to an instance
> - don't use hyperlinks for 'unknown', for detached volumes
> - don't use <--> separator in instances' volume list if no device specified (such as for FGCP)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (DTACLOUD-210) various small GUI improvements:
use hyperlinks for FWs and volumes in instances, allow name to be specified
for new volumes, display name when available, don't use hyperlink for 'unknown'
instances, don't use <--> if no device specified
Posted by "marios@redhat.com" <ma...@redhat.com>.
bump - after request from Dies - I'll try looking at this and others
tomorrow
On 04/05/12 09:16, Dies Koper (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/DTACLOUD-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Dies Koper updated DTACLOUD-210:
> --------------------------------
>
> Attachment: 0007-allow-volume-name-to-be-specified-in-GUI.patch
> 0006-use-hyperlinks-for-attached-volumes-in-instance-show.patch
> 0005-don-t-show-separator-if-no-device-name-available.patch
> 0004-don-t-use-hyperlink-for-unknown-for-detached-volume.patch
> 0003-change-button-name-for-volume-attaching-from-create-.patch
> 0002-use-volume-name-instead-of-id-for-volume-name-if-ava.patch
> 0001-use-hyperlinks-for-firewall-entries-in-instance-show.patch
>
> patches for each of the improvements
>
>> various small GUI improvements: use hyperlinks for FWs and volumes in instances, allow name to be specified for new volumes, display name when available, don't use hyperlink for 'unknown' instances, don't use <--> if no device specified
>> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>>
>> Key: DTACLOUD-210
>> URL: https://issues.apache.org/jira/browse/DTACLOUD-210
>> Project: DeltaCloud
>> Issue Type: Improvement
>> Components: Server
>> Reporter: Dies Koper
>> Assignee: David Lutterkort
>> Priority: Minor
>> Attachments: 0001-use-hyperlinks-for-firewall-entries-in-instance-show.patch, 0002-use-volume-name-instead-of-id-for-volume-name-if-ava.patch, 0003-change-button-name-for-volume-attaching-from-create-.patch, 0004-don-t-use-hyperlink-for-unknown-for-detached-volume.patch, 0005-don-t-show-separator-if-no-device-name-available.patch, 0006-use-hyperlinks-for-attached-volumes-in-instance-show.patch, 0007-allow-volume-name-to-be-specified-in-GUI.patch
>>
>>
>> Various small GUI improvements:
>> - use hyperlinks for FWs and volumes in instances to those resources
>> - allow optional name to be specified for new volumes
>> - use volume name instead of id for volume name when available
>> - rename create button to 'attach' to attach a volume to an instance
>> - don't use hyperlinks for 'unknown', for detached volumes
>> - don't use <--> separator in instances' volume list if no device specified (such as for FGCP)
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
[jira] [Updated] (DTACLOUD-210) various small GUI improvements: use
hyperlinks for FWs and volumes in instances, allow name to be specified for
new volumes, display name when available, don't use hyperlink for 'unknown'
instances, don't use <--> if no device specified
Posted by "Dies Koper (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DTACLOUD-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dies Koper updated DTACLOUD-210:
--------------------------------
Attachment: 0007-allow-volume-name-to-be-specified-in-GUI.patch
0006-use-hyperlinks-for-attached-volumes-in-instance-show.patch
0005-don-t-show-separator-if-no-device-name-available.patch
0004-don-t-use-hyperlink-for-unknown-for-detached-volume.patch
0003-change-button-name-for-volume-attaching-from-create-.patch
0002-use-volume-name-instead-of-id-for-volume-name-if-ava.patch
0001-use-hyperlinks-for-firewall-entries-in-instance-show.patch
patches for each of the improvements
> various small GUI improvements: use hyperlinks for FWs and volumes in instances, allow name to be specified for new volumes, display name when available, don't use hyperlink for 'unknown' instances, don't use <--> if no device specified
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DTACLOUD-210
> URL: https://issues.apache.org/jira/browse/DTACLOUD-210
> Project: DeltaCloud
> Issue Type: Improvement
> Components: Server
> Reporter: Dies Koper
> Assignee: David Lutterkort
> Priority: Minor
> Attachments: 0001-use-hyperlinks-for-firewall-entries-in-instance-show.patch, 0002-use-volume-name-instead-of-id-for-volume-name-if-ava.patch, 0003-change-button-name-for-volume-attaching-from-create-.patch, 0004-don-t-use-hyperlink-for-unknown-for-detached-volume.patch, 0005-don-t-show-separator-if-no-device-name-available.patch, 0006-use-hyperlinks-for-attached-volumes-in-instance-show.patch, 0007-allow-volume-name-to-be-specified-in-GUI.patch
>
>
> Various small GUI improvements:
> - use hyperlinks for FWs and volumes in instances to those resources
> - allow optional name to be specified for new volumes
> - use volume name instead of id for volume name when available
> - rename create button to 'attach' to attach a volume to an instance
> - don't use hyperlinks for 'unknown', for detached volumes
> - don't use <--> separator in instances' volume list if no device specified (such as for FGCP)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira