You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/05 12:21:34 UTC
[GitHub] [flink] StephanEwen opened a new pull request #11023:
[FLINK-15920][build] Show thread names in logs by default
StephanEwen opened a new pull request #11023: [FLINK-15920][build] Show thread names in logs by default
URL: https://github.com/apache/flink/pull/11023
## What is the purpose of the change
Having thread names in log lines make it much easier to understand from which task they come.
Enabling that by default on the CI setup helps with analyzing bugs and unstable tests.
This changes like layout from
```
00:34:49,997 INFO org.apache.flink.streaming.runtime.tasks.StreamTask - loading State ...
```
to
```
00:34:49,997 [MyWindow Operator (1/4)] INFO org.apache.flink.streaming.runtime.tasks.StreamTask - loading State ...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #11023: [FLINK-15920][build] Show
thread names in logs by default
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11023: [FLINK-15920][build] Show thread names in logs by default
URL: https://github.com/apache/flink/pull/11023#issuecomment-582394054
Azure setup isn't in master yet; either this change applies or something must be changed externally. In any case we can proceed with this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] asfgit closed pull request #11023: [FLINK-15920][build]
Show thread names in logs by default
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #11023: [FLINK-15920][build] Show thread names in logs by default
URL: https://github.com/apache/flink/pull/11023
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #11023: [FLINK-15920][build]
Show thread names in logs by default
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #11023: [FLINK-15920][build] Show thread names in logs by default
URL: https://github.com/apache/flink/pull/11023#issuecomment-582389649
@rmetzger would know more about the Azure setup. This is the only logging config I could find for the build setup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #11023: [FLINK-15920][build]
Show thread names in logs by default
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #11023: [FLINK-15920][build] Show thread names in logs by default
URL: https://github.com/apache/flink/pull/11023#issuecomment-582388657
Is this config file also used on the Azure setup? If not then we should probably also change that one. Other than that +1 to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11023: [FLINK-15920][build]
Show thread names in logs by default
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11023: [FLINK-15920][build] Show thread names in logs by default
URL: https://github.com/apache/flink/pull/11023#issuecomment-582383187
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 52d046bf087435f27d7486a71a8f2144ab900180 (Wed Feb 05 12:24:15 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11023: [FLINK-15920][build]
Show thread names in logs by default
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11023: [FLINK-15920][build] Show thread names in logs by default
URL: https://github.com/apache/flink/pull/11023#issuecomment-582394886
<!--
Meta data
Hash:1d5ea97eadf8f54a8f77f68a186def5ec02d7fe6 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1d5ea97eadf8f54a8f77f68a186def5ec02d7fe6
-->
## CI report:
* 1d5ea97eadf8f54a8f77f68a186def5ec02d7fe6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rmetzger commented on issue #11023: [FLINK-15920][build]
Show thread names in logs by default
Posted by GitBox <gi...@apache.org>.
rmetzger commented on issue #11023: [FLINK-15920][build] Show thread names in logs by default
URL: https://github.com/apache/flink/pull/11023#issuecomment-582395402
Even though the log file contains `travis` in its name, it'll probably work in Azure as well without a manual change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11023:
[FLINK-15920][build] Show thread names in logs by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11023: [FLINK-15920][build] Show thread names in logs by default
URL: https://github.com/apache/flink/pull/11023#issuecomment-582394886
<!--
Meta data
Hash:1d5ea97eadf8f54a8f77f68a186def5ec02d7fe6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147541209 TriggerType:PUSH TriggerID:1d5ea97eadf8f54a8f77f68a186def5ec02d7fe6
Hash:1d5ea97eadf8f54a8f77f68a186def5ec02d7fe6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4865 TriggerType:PUSH TriggerID:1d5ea97eadf8f54a8f77f68a186def5ec02d7fe6
-->
## CI report:
* 1d5ea97eadf8f54a8f77f68a186def5ec02d7fe6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147541209) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4865)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services