[jira] [Commented] (STREAMS-496) Remove twitter4j dependency from streams-provider-twitter

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STREAMS-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954102#comment-15954102 ] 

ASF GitHub Bot commented on STREAMS-496:
----------------------------------------

GitHub user steveblackmon opened a pull request:

    https://github.com/apache/incubator-streams/pull/360

    STREAMS-496: Remove twitter4j dependency from streams-provider-twitter

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/steveblackmon/incubator-streams STREAMS-496

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-streams/pull/360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #360
    
----
commit 7dedbb42251e1c5214690e32f12a5efb5032dc92
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-03-20T06:35:33Z

    STREAMS-496: WIP

commit a8fd796096296bb2e8af61b722c4a261acbba987
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-03-20T18:07:27Z

    more WIP

commit 68d7976f928173dbd6de636c58d1a23dbe95eb15
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-03-24T18:39:52Z

    STREAMS-496: additional pojos and interfaces needed to maintain features

commit c95bccd41b4f5f51d7e614e5927210458d1dbfbd
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-03-24T19:21:34Z

    implementations using RestClient

commit 78f30284caefb09e06818a9f435c3f380ee986a3
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-03-25T16:38:06Z

    STREAMS-496: WIP - twitter4j gone, src/main/java compiles

commit 0d172e76232e3d0bd48af8d6616716c444eb94f0
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-03-26T17:56:11Z

    STREAMS-496: consolidate httpcomponents version selection

commit 434657439abc0dde2998a8cb213d8e8398f43ad6
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-03-26T17:56:34Z

    first implementation of oauth signing

commit 1885090c6d683c8a9a6df7c64f933529378ee965
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-03-26T18:09:24Z

    cleanup authentication.  debugging ‘Bad Authentication data.’

commit edc2662fd68b9e1e04c20b8721a44a6ee9fb36e6
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-03-26T21:20:10Z

    adding unit testing to debug authentication

commit 5a07c57b553f8c87af1d42e0bbef4f0795f17bf7
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-03-26T22:44:37Z

    STREAMS-496: more unit tests, all passing, ITs still fail

commit c623f7139421049d5b536576c739b60e959cf11e
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-03-26T22:55:09Z

    STREAMS-496: going through guide word-by-word and debugging line-by-line looking for mistakes

commit eddf003ba5b5555b10c3d51267c00225b6da4ef1
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-03-27T03:46:19Z

    TwitterOAuthRequestInterceptorTest.testProcess
    
    TwitterOAuthRequestInterceptorTest.testProcess is pretty much directly off the twitter dev guidelines and tests the entire auth process at once.  passes. ITs still fail

commit 06845f2dd848c91971c10f194f0d5503d5f4a964
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-03-28T18:20:03Z

    return empty array not null on error

commit 517b85f02e93c51d5fa36a704f7f0e0e2cdaed4e
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-04-03T16:01:25Z

    oauth signing working

commit 069be4da745b9cd262159cca1982a9b52cb5cefc
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-04-03T19:56:01Z

    all integration tests passing using juneau 6.1.0-incubating

commit d7cd07110d602d24a07aad8e8f390ff0d98f1e19
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2017-04-03T20:11:32Z

    checkstyle clean up

----


> Remove twitter4j dependency from streams-provider-twitter
> ---------------------------------------------------------
>
>                 Key: STREAMS-496
>                 URL: https://issues.apache.org/jira/browse/STREAMS-496
>             Project: Streams
>          Issue Type: Task
>            Reporter: Steve Blackmon
>            Assignee: Steve Blackmon
>             Fix For: 0.5.1
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Per discussion on legal@ releases that include modules with the json license are not permitted after April 30, 2017.
> twitter4j has such a dependency and has shown little willingness to address it.
> Switch off twitter4j to HTTP API interaction.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)