[jira] [Commented] (CB-11558) Make windows plugin rm remove ProjectReference items

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-11558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401809#comment-15401809 ] 

ASF GitHub Bot commented on CB-11558:
-------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/185#discussion_r72956629
  
    --- Diff: template/cordova/lib/PluginHandler.js ---
    @@ -105,7 +105,7 @@ var handlers = {
                 var type = obj.type;
     
                 if(type === 'projectReference') {
    -                project.removeProjectReference(path.join(plugin.dir, src), getTargetConditions(obj));
    +                project.removeProjectReference(path.join('..', '..', 'plugins', plugin.id, src), getTargetConditions(obj));
    --- End diff --
    
    @daserge, please don't use hardcoded `../../plugins` path here. The idea here is that PlatformApi abstracts from cordova project structure so we ideally should not rely on presence of `plugins` directory two levels above. I'd rather calculate relative path from `plugin.dir` using `path.relative`


> Make windows plugin rm remove ProjectReference items
> ----------------------------------------------------
>
>                 Key: CB-11558
>                 URL: https://issues.apache.org/jira/browse/CB-11558
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>              Labels: triaged, windows
>
> {{cordova plugin add phonegap-plugin-barcodescanner}}
> CordovaApp.Windows.jsproj ->
> {noformat}
>     <ItemGroup>
>         <ProjectReference Include="..\..\plugins\phonegap-plugin-barcodescanner\src\windows\lib\WinRTBarcodeReader.csproj" />
>     </ItemGroup>
> {noformat}
> {{cordova plugin rm phonegap-plugin-barcodescanner}}
> {{ItemGroup}} not being removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org