[GitHub] [tvm] FranckQC edited a comment on pull request #9482: Implementation of Common Subexpression Elimination for TIR

[GitBox <gi...@apache.org>]

FranckQC edited a comment on pull request #9482:
URL: https://github.com/apache/tvm/pull/9482#issuecomment-1018993039


   Hi everyone.
   
   So sorry for the delayed answer.
   
   I have just pushed yesterday and today a few more commits that improve this CSE pass. The biggest improvement is the behavior of the pass for If and For nodes, for which expressions were previously allowed to be lifted out of the control flow scope.
   I spotted that thanks to the question of @wrongtest, so many thanks again for it.
   It was definitely a bad thing (although rare, and not breaking the semantics preservation) as it was an anti-optimization if a redundant was only present in one execution path (let's say the THEN branch of an If) to lift it just above the If, as it might never have been computed at all if the execution flows reach the ELSE branch.
   Now, it won't do these kind of things. Instead, it will introduce it at the beginning of the bloc where it is redundant, but it won't be lifted outside of it.
   
   The only things left are to re run clang-format and to address the last little things reported by the CI. However, the build already succeeds for both Windows and MacOS.
   I'm hoping to be done with everything by the end of the week-end, so that it can be merged next week for people to enjoy the CSE! I hope it will be useful.
   
   Kind regards,
   Franck


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org