You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/13 06:34:06 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #22934: Use appropriate TaskInstance object related to TaskFail to get execution_date

uranusjr commented on code in PR #22934:
URL: https://github.com/apache/airflow/pull/22934#discussion_r849124658


##########
airflow/models/taskfail.py:
##########
@@ -37,6 +39,9 @@ class TaskFail(Base):
     end_date = Column(UtcDateTime)
     duration = Column(Integer)
 
+    task_instance = relationship("TaskInstance", lazy='joined', innerjoin=True)

Review Comment:
   What would be the performance impact if we don’t set `lazy='joined'`? The TaskInstance object is large, so it’d be best if we could avoid pulling it in if possible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org